pcp
[Top] [All Lists]

Re: [pcp] pcp updates: container/man build fix

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: container/man build fix
From: Lukas Berk <lberk@xxxxxxxxxx>
Date: Thu, 28 Jul 2016 23:19:31 -0400
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <366785428.10085692.1469603214429.JavaMail.zimbra@xxxxxxxxxx> (Nathan Scott's message of "Wed, 27 Jul 2016 03:06:54 -0400 (EDT)")
References: <87mvl3x5zq.fsf@xxxxxxxxxx> <366785428.10085692.1469603214429.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux)
Hey,

Nathan Scott <nathans@xxxxxxxxxx> writes:
>> [...]
>>  src/include/builddefs.in |    8 +++++++-
>>  5 files changed, 23 insertions(+), 2 deletions(-)
[...]
> The added HAVE_MANPAGES there looks like a no-op, or is it needed in some
> subtle way?  (note that final && is after a variable assignment).  Is the
> intent perhaps to have a separate
>
> +    test $(HAVE_MANPAGES) || MAN_PAGES=""; \
>
> before the "for" loop?

Was essentially to skip that loop if the variable is empty, I've tweaked
it again with an 'if ... fi' conditional to make it more clear, been using
it all day to build pcp with and without containers.  Is in my master
branch upstream.

Cheers,

Lukas

<Prev in Thread] Current Thread [Next in Thread>