Changes committed to git://git.pcp.io/pcp.git master
Ken McDonell (11):
qa/709: notrun for any PCP_PLATFORM other than Linux (pmcollectl)
qa/666 & qa/common.check: handle broken Debian valgrind
qa/admin/pcp-daily: re-enable valgrind group on Debian stretch hosts
qa/578: increase tolerance for expected openfd values
qa/914: notrun if there are no real hardware counters here
qa/870: (new) test integrity of pmlogger control files
qa/381: additional diagnositics for debugging
qa/956: additional diagnositics for debugging
src/include/pcp.env: Mac OS X change
src/pmlogger/src/ports.c: fix broken logic for primary control file
src/pmie: honour SIGINT while parsing rules
Marko Myllynen (5):
zsh compilations: -w is not needed for _arguments
pmrep: really drop non-ascii
pmrep: consistent extended header with archives
pmrep: handle metrics with no instances
libvirt pmda: refactor and rename some metrics
Dave Brolley (1):
RHBZ 1348351: pmchart(1): Detect archives from the same host.
qa/1069.out | 6 -
qa/1070.out | 2
qa/381 | 14 ++
qa/578 | 21 ++--
qa/578.out | 12 +-
qa/666 | 3
qa/709 | 10 ++
qa/870 | 173 +++++++++++++++++++++++++++++++++++
qa/870.out | 7 +
qa/914 | 8 +
qa/956 | 4
qa/admin/pcp-daily | 5 -
qa/common.check | 12 ++
qa/group | 1
src/include/pcp.env | 9 +
src/libpcp_qmc/src/qmc_group.cpp | 4
src/pmchart/groupcontrol.cpp | 3
src/pmchart/groupcontrol.h | 3
src/pmchart/main.cpp | 2
src/pmdas/libvirt/pmdalibvirt.python | 171 +++++++++++++++++++---------------
src/pmie/src/dstruct.c | 1
src/pmie/src/dstruct.h | 1
src/pmie/src/eval.c | 2
src/pmie/src/lexicon.c | 4
src/pmie/src/pmie.c | 8 +
src/pmlogger/src/ports.c | 119 +++++++++++++++++++-----
src/pmrep/pmrep.py | 14 +-
src/zshrc/_pcp | 40 ++++----
28 files changed, 497 insertions(+), 162 deletions(-)
commit 9e96cf4356ad7a8eb45b1679aec1b8429b7e836b
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Fri Jul 22 10:23:22 2016 +1000
libvirt pmda: refactor and rename some metrics
Refactoring and preparatory work for persistent metric IDs.
Start by first by renaming current metric names to ...all...,
which they really are; we can then add device specific metrics
later without changing any current metrics.
commit 044271f02eaf90be4674b902f97ff9c1521dc2ba
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Fri Jul 22 10:21:52 2016 +1000
pmrep: handle metrics with no instances
pmfg requires to use extend_indom() with metrics with no current
instances. We allow that so that something like "pmrep proc" works
again. Only the first instance will be reported, that is the same
behavior as with pre-pmfg pmrep.
commit f832fff57fd5bc9686f84141bc42560f16e9cbbf
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Fri Jul 22 10:21:01 2016 +1000
pmrep: consistent extended header with archives
In 13cf235 the purpose was to always report the actual archive end time
in the extended header but due to braino the change was done only with
-u, now really do so to make the extended header consistent with archives
regardless of command line options.
commit de98848d039ceff533385bbee080c3a7ef2abf63
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Fri Jul 22 10:20:15 2016 +1000
pmrep: really drop non-ascii
Drop the one that slipped away, no-op now anyway.
commit a40abc6e00cde8450528b7b638b40f964e077147
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Fri Jul 22 10:19:52 2016 +1000
zsh compilations: -w is not needed for _arguments
-w was unneeded and in fact incorrect:
The combination of -s with -w allows single-letter
options to be combined in a single word even if one or
more of the options take arguments. For example, if -a
takes an argument, with no -s `-ab' is considered as a
single (unhandled) option; with -s -ab is an option with
the argument `b'; with both -s and -w, -ab may be the
option -a and the option -b with arguments still to come.
That is, with -w, -xy <tab> arguments for -x would be completed.
commit 1294cedb151a1d25790cf4b7af1c5b810110f6a4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jul 22 07:27:49 2016 +1000
src/pmie: honour SIGINT while parsing rules
pmie has an atexit() handler that requires deferred SIGINT processing
when evaluating rules ... unfortunately this also blocked SIGINT
processing forever in the earlier stages when rules are being parsed
(especially when read from <stdin>).
Fixes RH BZ 1327226.
commit e607bbc64a18e7ad8c50503341dd3119231804e7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jul 22 06:48:38 2016 +1000
src/pmlogger/src/ports.c: fix broken logic for primary control file
This was the root cause of the qa/1108 failures.
The logic that checked for and stopped more than one primary pmlogger
from running was broken. Specifically using stat() instead of
lstat() to check for a symbolic link will always fail, which drove
us down the "old-style hardlink" path and unconditionally removed
$PCP_TMP_DIR/pmlogger/primary before the existance check that was
intended to stop multiple primary loggers from running.
This error seems to have been introduced in commit 7148bf11 (almost
12 months ago) ... sigh.
And to compound the problem, a primary pmlogger was conditionally
removing $PCP_TMP_DIR/pmlogger/primary at exit, meaning that if we
ever got 2 (or more!) primary pmloggers running and either of them
exited the control files would be removed and pmlogger_check would
stumble along later and start another primary pmlogger running.
So now we are checking the pid from the symlink and only removing
the primary control file if this instance of pmlogger created it.
Also cleaned up some misleading diagnostics.
commit 7ca4c81e25425aa592a0b853e1bebb55843031e2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jul 22 06:46:15 2016 +1000
src/include/pcp.env: Mac OS X change
In _get_pids_by_name() we need to also accommodate ps(1) output that
has the executable name enclosed in () ... this was causing QA failures
for qa/956 on Mac OS X.
commit d4858c9de1ff9dc86601cbc42f5633e94ed17f58
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jul 22 06:45:03 2016 +1000
qa/956: additional diagnositics for debugging
commit dc6dfd1ff23b5102f147e8a87f09502ffe4f6150
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jul 22 06:44:30 2016 +1000
qa/381: additional diagnositics for debugging
commit 4a9298eab7b86504f3287c2386483efde17fa663
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jul 22 06:32:40 2016 +1000
qa/870: (new) test integrity of pmlogger control files
These are the ones in $PCP_TMP_DIR/pmlogger. And getting this test
to pass will address the root cause of the non-deterministic qa/1108
failures.
This test can be run with a --check argument which silently (if all
is well) runs the integrity check without any of the test cases.
In this form, could be used with check.callback to run the check
after every test to help identify any test that leaves the control
files in a bad state.
commit 205137e0268884cf9b0c59823d039ec541653c45
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Thu Jul 21 11:55:45 2016 -0400
RHBZ 1348351: pmchart(1): Detect archives from the same host.
The archives specified on separate -a options must be from different hosts.
pmchart(1) was failing to detect this. Failure to detect this results
in only the first archive for each host being visible to pmchart(1).
This was the cause of the errors being reported in the bug report.
pmchart(1) will now issue an error message reporting the duplicate
hosts and suggest combining them using pmlogextract(1).
commit 00ae066eedfaa1ef971a15266ffb00733e997b9b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 20 11:12:33 2016 +1000
qa/914: notrun if there are no real hardware counters here
The PAPI PMDA may have been built, but the platform may be lame
hardware or a crippled VM with no support for hardware counters.
commit 6c58b9e89dbf04d67d991831a1f61e4ed24281fd
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 20 09:58:28 2016 +1000
qa/578: increase tolerance for expected openfd values
Based on a suggestion from Nathan that the failures in this test
may be related to non-determinism coming from the recently added
parallelism in the socket connection code, change the filtering to
accept +/-1 from the (previously) expected value.
commit fe6f79f6af659b63e105413ed8d8e472b5c54ebe
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 20 09:39:10 2016 +1000
qa/admin/pcp-daily: re-enable valgrind group on Debian stretch hosts
commit 3156256a4b85eeefde4b515f3ed1b38c85c4b098
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jul 20 09:37:49 2016 +1000
qa/666 & qa/common.check: handle broken Debian valgrind
Filter out bogus lines from the current Debian stretch version
of valgrind.
commit f22f7a9d60a381ce8e647f798d2ed139b5437a97
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Jul 19 20:12:27 2016 +1000
qa/709: notrun for any PCP_PLATFORM other than Linux (pmcollectl)
|