pcp
[Top] [All Lists]

Bug#805955: [pcp] Bug#805955: pcp: FTBFS when built with dpkg-buildpacka

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Bug#805955: [pcp] Bug#805955: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)
From: Santiago Vila <sanvila@xxxxxxx>
Date: Thu, 21 Jul 2016 13:24:56 +0200 (CEST)
Cc: 805955@xxxxxxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1728856132.7554720.1469057912808.JavaMail.zimbra@xxxxxxxxxx>
References: <E1bNooB-0001FN-27@xxxxxxxxxxxxxxxxxxxxxx> <363843620.6970954.1468912367736.JavaMail.zimbra@xxxxxxxxxx> <alpine.DEB.2.11.1607191034220.18373@xxxxxxxxxxxxxxxxxxxxxxxxx> <1728856132.7554720.1469057912808.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Santiago Vila <sanvila@xxxxxxx>, 805955@xxxxxxxxxxxxxxx
Resent-cc: PCP Development Team <pcp@xxxxxxxxxxx>
Resent-date: Thu, 21 Jul 2016 11:27:06 +0000
Resent-from: Santiago Vila <sanvila@xxxxxxx>
Resent-message-id: <handler.805955.B805955.146910031431947@xxxxxxxxxxxxxxx>
Resent-to: debian-bugs-dist@xxxxxxxxxxxxxxxx
User-agent: Alpine 2.11 (DEB 23 2013-08-11)
On Wed, 20 Jul 2016, Nathan Scott wrote:

> > > Actually some advice would be great, having had an initial look into
> > > this one now.  Patch below shows the basic split we'll need to make
> > > the architecture independent packages generated separately, but I'm
> > > not sure how to fit that split into the rest of the rules file (I get
> > > the same sort of errors with a change like this in place no matter
> > > what I try - maybe its obvious to someone more deb knowledgeable?).
> > 
> > I have not tested the patch but I see why it would not work.
> > 
> > Try putting "dh_builddeb" somewhere in binary-indep, otherwise the
> > actual .deb packages will not be created.
> > 
> > Thanks.
> > 
> 
> Taa.  I see problems in the binary-indep target before the build reaches
> that stage though.  The debian/rules uses dh_install(1) - in particular,
> it relies on this behaviour from the man page...
> 
>     On the other hand, maybe you have a large package that builds
>     multiple binary packages. You can use the upstream Makefile to
>     install it all into debian/tmp, and then use dh_install to copy
>     directories and files from there into the proper package build
>     directories.
> 
> And dh_install fails when used by the binary-indep target - it requires
> files from both binary-indep and binary-arch, I think.

That should not happen unless you are creating packages that have to
conflict at each other because they contain the same files.

> Does that mean dh_install can no longer be used for these targets
> as described above or does that stage need to done elsewhere?
> (before dh_builddeb I'm sure)

You can probably use dh_install here, but I see that you are using
dh_install with --sourcedir. While this is supported, I would
recommend that you do "make install" to debian/tmp first
(not to debian/firstpackage) and use the already existing
debian/*.install files to tell dh_install which files go to which
packages.

This usually makes debian/rules to be more simple and easier to
understand, and it also makes the future switch to "dh" easier.

Thanks.

<Prev in Thread] Current Thread [Next in Thread>