pcp
[Top] [All Lists]

pcp updates: merges, qa

To: PCP <pcp@xxxxxxxxxxx>
Subject: pcp updates: merges, qa
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 19 Jul 2016 02:03:36 -0400 (EDT)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <236811100.6960630.1468908186675.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: Se2+a1pf0dsSLhWbQJTxjEliFUeEzw==
Thread-topic: pcp updates: merges, qa
Changes committed to git://git.pcp.io/pcp.git master

Nathan Scott (4):
      qa: handle libvirt PMDA being installed but with no data source
      qa: add libvirt PMDA to the usual optional-PMDA filters
      pmdalinux: handle edge case of no /proc/softirqs file at all
      qa: fix the fallout from pminfo batch size increase

Marko Myllynen (3):
      libvirt pmda: enhancements to api version detection logic
      pminfo: increase default batch size
      libvirt pmda: adjust block dev metrics collection

Ken McDonell (2):
      qa/003: No values is OK for kernel.percpu.softirqs.none
      qa/common.check: clean up the logic for testing which valgrind options 
are available

Alec Ten Harmsel (1):
      pcp2influxdb: clarify diagnostics for certain failure conditions


 man/man1/pminfo.1                    |    2 
 qa/003                               |    1 
 qa/1043                              |   34 ++++++
 qa/1043.out                          |    6 +
 qa/249.out                           |  174 +++++++++++++++++------------------
 qa/344.out                           |   44 ++++----
 qa/359                               |    1 
 qa/common.check                      |   14 ++
 qa/common.filter                     |    2 
 qa/group                             |    1 
 src/libpcp_pmda/src/dynamic.c        |    2 
 src/pcp2influxdb/pcp2influxdb.py     |   31 ++++--
 src/pmdas/libvirt/Install            |    2 
 src/pmdas/libvirt/connect            |   16 ++-
 src/pmdas/libvirt/pmdalibvirt.python |   13 --
 src/pmdas/linux/interrupts.c         |   70 +++++++++++---
 src/pminfo/pminfo.c                  |    4 
 17 files changed, 266 insertions(+), 151 deletions(-)


commit cbce81e5b3512cfddc4df4f70fe7fdba555df5d3
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jul 19 16:01:06 2016 +1000

    qa: fix the fallout from pminfo batch size increase

commit cc58fe2eb697ffa923f1351eb2f912335c5302a9
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date:   Tue Jul 19 13:33:10 2016 +1000

    libvirt pmda: adjust block dev metrics collection
    
    libvirt.git/src/libvirt-domain.c says:
    
     * VIR_DOMAIN_STATS_BLOCK: Return block devices statistics.  By default,
     * this information is limited to the active layer of each <disk> of the
     * domain (where block.count is equal to the number of disks), but adding
     * VIR_CONNECT_GET_ALL_DOMAINS_STATS_BACKING to @flags will expand the
     * array to cover backing chains (block.count corresponds to the number
     * of host resources used together to provide the guest disks).
    
    I think we could perhaps at least start without that flag, and if needed
    then provide an configuration option to enable it.  For reference, in case
    the backing flag is considered later, this comment from the file mentioned
    above should be kept in mind:
     * "block.<num>.backingIndex" - unsigned int giving the <backingStore> 
index,
     *                              only used when backing images are listed.

commit 241334eecbc752491028f4dd87ee65292b1c3bbd
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date:   Tue Jul 19 13:19:45 2016 +1000

    pminfo: increase default batch size
    
    pminfo(1) default batch size setting predates git history,
    other clients seem to fetch lots of metrics at once, let's
    increase the default for pminfo(1) as well.

commit 600723bef48604d45ad4e1bd23541b4d4805ce07
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Jul 18 19:16:20 2016 +1000

    pmdalinux: handle edge case of no /proc/softirqs file at all
    
    Ken came across this situation on a couple hosts in the QA farm.

commit 4c59a8a4e9253dd86af8d024ac4451922d924364
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Jul 18 14:26:51 2016 +1000

    qa: add libvirt PMDA to the usual optional-PMDA filters

commit c80f3db9cceeb912f07d61d92030f44eddd25ae9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Jul 18 12:47:06 2016 +1000

    qa: handle libvirt PMDA being installed but with no data source

commit 65af2a430f33f00360bbcef9323f8c53f5934d74
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Jul 19 08:17:10 2016 +1000

    qa/common.check: clean up the logic for testing which valgrind options are 
available
    
    Was failing on vm04 because --show-possibly-lost is not supported
    but the guards in common.check were not testing this properly.

commit a02786db47a8a8379d5308e9fabc4b2005cad5ba
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Jul 19 07:04:49 2016 +1000

    qa/003: No values is OK for kernel.percpu.softirqs.none

commit cde6763548caeaf266a3aaf91b7803f9a4021d2a
Author: Alec Ten Harmsel <alec@xxxxxxxxxxxxxxxxxx>
Date:   Mon Jul 18 12:16:19 2016 +1000

    pcp2influxdb: clarify diagnostics for certain failure conditions
    
    Add some more helpful error messages.  It now prints warnings in the
    following situations that it did not before:
    
    * The python requests package is not installed (also hard exits after
          printing the message)
    * The HTTP request returns 404 (most likely the requested database does
          not exist)
    * The connection fails

commit 069ea4d5de0ad08c845f84ae13dffaa6517bf70e
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date:   Mon Jul 18 12:10:59 2016 +1000

    libvirt pmda: enhancements to api version detection logic
    
    This also updates Install which was still using temp domain ID.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: merges, qa, Nathan Scott <=