pminfo(1) default batch size setting predates git history,
other clients seem to fetch lots of metrics at once, let's
increase the default for pminfo(1) as well (this is very
moderate increase IMHO, could probably be higher, unless
of course there's some historical reason for this value).
---
man/man1/pminfo.1 | 2 +-
src/pminfo/pminfo.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/man/man1/pminfo.1 b/man/man1/pminfo.1
index 91063ba..4ec8e88 100644
--- a/man/man1/pminfo.1
+++ b/man/man1/pminfo.1
@@ -114,7 +114,7 @@ and
.B \-v
options. The default value for
.I batchsize
-is 20.
+is 128.
.PP
Other options control the specific information to be reported.
.TP 5
diff --git a/src/pminfo/pminfo.c b/src/pminfo/pminfo.c
index 9108bde..4028770 100644
--- a/src/pminfo/pminfo.c
+++ b/src/pminfo/pminfo.c
@@ -36,7 +36,7 @@ static pmLongOptions longopts[] = {
PMOPT_VERSION,
PMOPT_HELP,
PMAPI_OPTIONS_HEADER("Protocol options"),
- { "batch", 1, 'b', "N", "fetch N metrics at a time for -f and -v [20]"
},
+ { "batch", 1, 'b', "N", "fetch N metrics at a time for -f and -v [128]"
},
{ "desc", 0, 'd', 0, "get and print metric description" },
{ "fetch", 0, 'f', 0, "fetch and print values for all instances" },
{ "fetchall", 0, 'F', 0, "fetch and print values for non-enumerable
indoms" },
@@ -71,7 +71,7 @@ static int need_context; /* set if need a pmapi context
*/
static int need_pmid; /* set if need to lookup names */
static char **namelist;
static pmID *pmidlist;
-static int batchsize = 20;
+static int batchsize = 128;
static int batchidx;
static int verify; /* Only print error messages */
static int events; /* Decode event metrics */
Thanks,
--
Marko Myllynen
|