pcp
[Top] [All Lists]

Re: [performancecopilot/pcp] pcp-pidstat: initial commit of PCP implemen

To: performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject: Re: [performancecopilot/pcp] pcp-pidstat: initial commit of PCP implementation of pidstat (#97)
From: Nathan Scott <notifications@xxxxxxxxxx>
Date: Tue, 05 Jul 2016 21:51:05 -0700
Cc:
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1467780665; bh=SGGF1L+S+tf2bbBbKGHnjGYAHdCVQoRyI7JFECuJFCc=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TOn0AqhdcGD7Hkbd/nrgJgD+apn1erfXJxOxv4c/sOTqQe8oKpSK7MrpO1xqeisji xe4q1Q/OL1PLho3ZJ9Io8iCVV98+CtL+yMMxlMG0GZzECqUHgg7hZl9uxmUjg6o6YM pXBxFIf7ewP0B7jywxDECi8X91WqXkWKzLYLL6+E=
In-reply-to: <performancecopilot/pcp/pull/97@xxxxxxxxxx>
List-archive: https://github.com/performancecopilot/pcp
List-id: performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b6f2e264592edfff50d1b511657ec5a522d8b610fe92cf000000011394503992a169ce09c65d1c@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b6f2e264592edfff50d1b511657ec5a522d8b610fe92cf000000011394503992a169ce09c65d1c@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0ItuTU4J5QGUehEHDm5y0aaD98-_aaks5qSzQ5gaJpZM4JFvTF>
References: <performancecopilot/pcp/pull/97@xxxxxxxxxx>
Reply-to: performancecopilot/pcp <reply+00bd08b6f2e264592edfff50d1b511657ec5a522d8b610fe92cf000000011394503992a169ce09c65d1c@xxxxxxxxxxxxxxxx>

Nice work Sitaram, looks good!

I'm seeing a failure in the new test qa/1078 - looks like two small things:

  • We need to use -z to provide deterministic timestamps in the test output (I have a fix for this one)
  • The individual processes are output in a different order for me - I guess different python version or different dictionary/hashing algorithm, or something like that. Is there a way to sort the pcp-pidstat output? (e.g. by pid or by top cpu user, or something like that - just to get that deterministic output). I'm not seeing it from a quick man page scan.

cheers.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<Prev in Thread] Current Thread [Next in Thread>