pcp
[Top] [All Lists]

Re: [pcp] Reporting archive timezone

To: Marko Myllynen <myllynen@xxxxxxxxxx>
Subject: Re: [pcp] Reporting archive timezone
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 5 Jul 2016 22:54:35 -0400 (EDT)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <577A1A0F.4010708@xxxxxxxxxx>
References: <577A1A0F.4010708@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: iESDky/7JCxc2Y36AwSXrh4pLcafAQ==
Thread-topic: Reporting archive timezone

----- Original Message -----
> [...]
> pmval handles this correctly, without -Z/-z it reports first metric at
> 06:53:01 which was 9 hours earlier at EET-2 than 15:53 at AEDT-11.

>From my scanning of the code, I believe pmval really doesn't touch the
timezone settings ($TZ etc) at all in the default case ...

> pmdumptext/pmrep however report first metric at 07:53:03, thus they
> report as it had been EEST-3 here in February. (With -Z/-z both
> pmdumptext and pmrep use the correct time.)

... whereas pmdumptext does always modify TZ to what it works out the
local timezone to be - perhaps there's something unexpected happening
there for pmdumptext.

> Below is a patch to fix pmrep to do the same as pmval.

I think that's a good strategy here, pmval is certainly using a simpler
approach.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>