pcp
[Top] [All Lists]

RE: [pcp] RFC: allowing longer metric and instance names in MMV(5) forma

To: "'Nathan Scott'" <nathans@xxxxxxxxxx>, "'Paul Smith'" <psmith@xxxxxxxxxx>, "'Ryan Doyle'" <rdoyle@xxxxxxxxxx>, "'Suyash'" <dextrous93@xxxxxxxxx>, "'Lukas Berk'" <lberk@xxxxxxxxxx>
Subject: RE: [pcp] RFC: allowing longer metric and instance names in MMV(5) format
From: "Ken McDonell" <kenj@xxxxxxxxxxxxxxxx>
Date: Thu, 30 Jun 2016 07:01:06 +1000
Cc: "'pcp developers'" <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <354261953.2889296.1467178515176.JavaMail.zimbra@xxxxxxxxxx>
References: <236242739.2883373.1467174433044.JavaMail.zimbra@xxxxxxxxxx> <354261953.2889296.1467178515176.JavaMail.zimbra@xxxxxxxxxx>
Thread-index: AQHXm0lvP9ch8R/hfZdqXTgxM6r06J/1Wgng
> -----Original Message-----
> From: pcp-bounces@xxxxxxxxxxx [mailto:pcp-bounces@xxxxxxxxxxx] On Behalf Of
> Nathan Scott
> Sent: Wednesday, June 29, 2016 3:35 PM
> To: Paul Smith <psmith@xxxxxxxxxx>; Ryan Doyle <rdoyle@xxxxxxxxxx>; Suyash
> <dextrous93@xxxxxxxxx>; Lukas Berk <lberk@xxxxxxxxxx>
> Cc: pcp developers <pcp@xxxxxxxxxxx>
> Subject: [pcp] RFC: allowing longer metric and instance names in MMV(5) format
> 
> ...

+1 ... good plan.

I've tweaked the patch a little to make the language more consistent (attached) 
and have a couple of observations ...

1. It does not appear that an Indoms2 section is needed (it was referred to but 
not defined).
2. I don't recall what the "Unused padding (zero filled)" entries are for in 
the Instance and Metric entries, but could we (a) drop them from the Instance2 
and Metric2 entries, and/or give them a better description in the man page (are 
they reserved for internal use, or some sort of backwards compatibility thing?)

Attachment: mmv.5.ken.patch
Description: Binary data

<Prev in Thread] Current Thread [Next in Thread>