myllynen wrote:
> [...]
>>> - pmfg rejects metrics like pmcd.pmie.configfile which pmval/pmrep/etc
>>> accept [...]
pmcd.pmie.configfile is a metric with an indom. Make sure you use
extend_item while identifying an instance, or else use extend_indom.
(I don't have your code working here, and I haven't seen the exact
error you encounter, so can't be more specific just now.)
>>> - in QA 1069 for sample.seconds we get 1 (integer) unlike with
>>> pmval/pmrep which give typically something like ~0.999-1.001 and for
>>> sample.milliseconds we get ~1000.002 or such where pmval/pmrep report
>>> ~1.000.
>> [...]
This is because the pmfg layer does not presume that second/second is
the appropriate rate-conversion target for any sort of time rate. It
will rate-convert automatically via a "/second" denominator only, so
in the default case the output value would be in "milliseconds/second".
That explains exactly the 1000 number.
Note that pmval.c lines 221-224 performs the second/second numerator
conversion heuristic in the application, as does the previous pmrep.py
(line 1261...). You could bring that logic forward into the new pmfg
pmrep, or change the testsuite to accept the different-but-correct
ms/s-scaled numbers.
- FChE
|