Hi Marko,
----- Original Message -----
> Hi,
>
> Here's draft to add support for containers in the Python PMAPI.
>
Awesome.
> A follow-up patch for pmrep will use this and it works nice, however
> for a reason not instantly clear to me this breaks --help output for
> all clients (breaks == formats poorly).
Hmm - which clients do you mean? e.g. pminfo is as before AFAICT.
> Also, I'm not sure is the pmoptget.c change needed/wanted?
Yep, looks good.
> Additionally, I'm not sure should error handling / exit happen
> in libpcp or in Python in cases like
> https://bugzilla.redhat.com/show_bug.cgi?id=1348186.
>
I think improvements to error handling will need to be driven from the
server side (PMCD/PMDAs, IOW). Some places have been improved, but
there's evidently still others where a more appropriate error should
be sent back ...
$ pmerr -l | grep CONTAINER
-12399 PM_ERR_NOCONTAINER Container not found
I extended things a little, esp qa/722 to use your test script update;
please double check that for me? Taa (commit 8421eae258c6)
cheers.
--
Nathan
|