pcp
[Top] [All Lists]

Re: Shouldn't pmrep use the default config file?

To: pcp@xxxxxxxxxxx
Subject: Re: Shouldn't pmrep use the default config file?
From: Jamie Bainbridge <jamie.bainbridge@xxxxxxxxx>
Date: Fri, 17 Jun 2016 16:00:15 +1000
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=dijAUhi/yeM97yPYLJtNKP73YAsZdKmG95g92INXr3U=; b=GPLjaIua6zUiOJALnKdyKMhQIUH5h6g0NfGQJZ/iLPLWGniKDfxRISXjzTbYFz7fXg YvH5YVhXFDqTvczkJxG/FVA3lDFiuU4/UyyzxfK+IftSEQ6VrSE+dE44+sP8bsF556vZ qmB6gxkIeMairAHLl1l6T2zdIvksGnutfQUqpT1M21jNd+FltL5LJiUbUf+WlrK1/lDc RyPuSfeS/YRWshjpliurBmnt75VHixfY/XGDPJbLtAjM+t6N+5JaAl4HMgfDAxKM9NoJ m8Rk328oMoX4xUhV1FusmLywExCwayzNMNzXMgm+myFBlaLyZ020CqZxPx0Y/15PkSjR Px9g==
In-reply-to: <CAAvyFNhgfmuLhAHfA3d1rUuiPE791=04QXQHeLy9Dq4F=_756w@xxxxxxxxxxxxxx>
References: <CAAvyFNhgfmuLhAHfA3d1rUuiPE791=04QXQHeLy9Dq4F=_756w@xxxxxxxxxxxxxx>
On 17 June 2016 at 10:35, Jamie Bainbridge <jamie.bainbridge@xxxxxxxxx> wrote:
> The pmrep manpage invites you to use a metric spec, but this does not
> work by default:
>
> # pmrep -p -b MB vfs.inodes.count :vmstat
> Metric set definition ':vmstat' not found.
>
> One has to specify the supplied config file for the command to work:
>
> # pmrep -p -b MB vfs.inodes.count -c /etc/pcp/pmrep/pmrep.conf :vmstat
>
> Shouldn't pmrep use this default config file, and users can
> modify/specify their own if they want to? This probably provides a
> better initial experience and is more in line with other tools with a
> config file.
>
> If you're happy with this, lmk and I'll submit a patch.

Thinking more on this, it would make even more sense to have a
directory like /etc/pcp/pmrep/pmrep.conf.d/ and read every *.conf file
in there on launch.

That way users could write their own tool, throw it in the directory,
and have it just work when they run "pmrep :mything".

This also makes it neater for the project to pre-package tools, as
each set of related pmrep tools (eg: each "sar" option implementation)
is broken into its own file.

Jamie

<Prev in Thread] Current Thread [Next in Thread>