Changes committed to git://git.pcp.io/pcp.git master
Mark Goodwin (2):
libpcp: plug memory leak in derived metrics error handling
qa - add qa/923 test for memleak in derive metric error handling
Nathan Scott (1):
qa: stash extra rc_pmcd verification warning on multi-host 365
qa/365 | 4 +++-
qa/923 | 25 +++++++++++++++++++++++++
qa/923.out | 11 +++++++++++
qa/group | 1 +
src/libpcp/src/derive.c | 25 +++++++++++++++----------
5 files changed, 55 insertions(+), 11 deletions(-)
Details ...
commit 5b3016404a16fb0b120250136bc14ea1f4794db1
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Jun 16 14:11:14 2016 +1000
qa: stash extra rc_pmcd verification warning on multi-host 365
These warnings are reported earlier on, in pmcd verification as
well now (and reported in the test later), so send the initial
expected warnings to seq.full and proceed as before. Diagnostic
caliper points are also logged around the startup messages now.
commit 693fd2068265168e7887df24c976d2a8e6bde766
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Thu Jun 16 14:03:29 2016 +1000
qa - add qa/923 test for memleak in derive metric error handling
qa/923 uses valgrind to check the fix for the memleak. RHBZ #1331973
new file: qa/923
new file: qa/923.out
modified: qa/group
commit 188987bde837f6f81c259903ab08824bcd008214
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Jun 15 17:54:45 2016 +1000
libpcp: plug memory leak in derived metrics error handling
BZ #1331973
Error handling needs to recursively free the current node, since it
may have been built recursively, so call free_expr() instead of free()
in the appropriate places where a derived expression fails. The patch
also fortifies free_expr() itself a bit.
Passes qa for group 'derive', and Frank's valgrind repro script passes
now too. A new QA test should probably be added.
BTW, this is not a regression per-se - the leak has always been there -
it's just more noticeable now that global derived metrics defs are loaded
by default.
|