https://bugzilla.redhat.com/show_bug.cgi?id=1331973
Mark Goodwin <mgoodwin@xxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nathans@xxxxxxxxxx |mgoodwin@xxxxxxxxxx
--- Comment #4 from Mark Goodwin <mgoodwin@xxxxxxxxxx> ---
Created attachment 1168237
--> https://bugzilla.redhat.com/attachment.cgi?id=1168237&action=edit
patch to fix memory leak in derived metric error handling
Error handling needs to recursively free the current node, since it may have
been built recursively, so call free_expr() instead of free() in the
appropriate places where a derived expression fails. The patch also fortifies
free_expr() itself a bit.
Passes qa for group 'derive', and Frank's valgrind repro script passes now too.
A new QA test should probably be added.
BTW, this is not a regression per-se - the leak has always been there - it's
just more noticeable now that global derived metrics defs are loaded by
default.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=FepqdidSSq&a=cc_unsubscribe
|