pcp
[Top] [All Lists]

Re: [pcp] [Patch]Add the metric from system call semctl/msgctl/shmctl

To: Liming Wu <wulm.fnst@xxxxxxxxxxxxxx>
Subject: Re: [pcp] [Patch]Add the metric from system call semctl/msgctl/shmctl
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 25 May 2016 06:57:56 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <6A799D6419DDBA43B657744DC4113882FE3F5CD0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <6A799D6419DDBA43B657744DC4113882FE3F5CD0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: AdG2c23VzMCboxbaTcKkcALTsRkpmgEllLcC
Thread-topic: [Patch]Add the metric from system call semctl/msgctl/shmctl
Hi Liming,

----- Original Message -----
> Hi ï
> 
>   This 2 patches add the metric from system call shmctl(..,SHM_INFO,..)
>   semctl(..,SEM_INFO,..)  and  msgctl(..,MSG_INFO,..). to pmdalinux.
>   After add these metrics , I want to add pmipcs command to replace of
>   Ipcs(-u/-l) command. If you have any suggestion,  please tell me.
>   

Sounds good!  Please have a look at scripts like src/pcp/{free,uptime} as
examples of how best to approach doing the new tool (should be a pcp-ipcs
with new man page, QA tests, and a src/pmlogconf/tools/ipcs file).

Also, could you look into writing a test case for these new metrics too,
please?  The qa/888 example from earlier today should be close to what is
needed for regression testing here too.  Thanks!

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>