pcp
[Top] [All Lists]

Re: [pcp] [patch]Add the metric of ipc.shm.used_ids

To: Liming Wu <wulm.fnst@xxxxxxxxxxxxxx>
Subject: Re: [pcp] [patch]Add the metric of ipc.shm.used_ids
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 24 May 2016 20:11:53 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <6A799D6419DDBA43B657744DC4113882FE3F5BB3@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <6A799D6419DDBA43B657744DC4113882FE3F5BB3@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: AdG1lYGtq0vK1Nz/SSmphUIFInWv4S0QDTBW
Thread-topic: [patch]Add the metric of ipc.shm.used_ids
Hi Liming,

----- Original Message -----
> Hi:
> 
>   When I see ipc shared memory metrics, I find there is no metric about the
>   number
>   of currently existing segments. I think it's needed. So make this patch to
>   add the metric.
> 

Looks good to me, its merged now.  I've also updated test qa/888 to add testing
coverage for this code - could you review commit 001cf95e5948 for me please?

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>