pcp
[Top] [All Lists]

Re: [performancecopilot/pcp] Fixes crashes and problems updating metrics

To: performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject: Re: [performancecopilot/pcp] Fixes crashes and problems updating metrics (#92)
From: Anthony DeChiaro <notifications@xxxxxxxxxx>
Date: Mon, 16 May 2016 09:41:56 -0700
Cc:
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1463416916; bh=+gjyAwnYhwPD7XtnV+tP83kEL9kcIHXeppDdaqLlFWE=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dbmJVfJzYngqZzc0hvmHXZTX/D0MSfkOPiZu+iI24Fav58e59z6aJlt7QfuDMCfub fjHflwlOb5WMuam0wV0s9YpmAeccnkrmQ0Tw7Xrb9sp9UjXJxwyyq/PRYm5DIKt2p6 STK9yc+FFxri15jqsTKhfCdkayLPWCisdb9zYTZ8=
In-reply-to: <performancecopilot/pcp/pull/92@xxxxxxxxxx>
List-archive: https://github.com/performancecopilot/pcp
List-id: performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b65a86829a63359350b8f2d9272ae11a66f1f8573192cf000000011351ba5492a169ce093a5ee6@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b65a86829a63359350b8f2d9272ae11a66f1f8573192cf000000011351ba5492a169ce093a5ee6@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0Ittwar-_hKnhJMCQFHZWSZlzu4YWiks5qCJ5UgaJpZM4Iedz1>
References: <performancecopilot/pcp/pull/92@xxxxxxxxxx>
Reply-to: performancecopilot/pcp <reply+00bd08b65a86829a63359350b8f2d9272ae11a66f1f8573192cf000000011351ba5492a169ce093a5ee6@xxxxxxxxxxxxxxxx>
Taking a second look, there's only really 2 issues with the example code in
mmv.py. The typeof and semantics constants weren't defined so I changed
them to reference the PM_ types in cpmapi. Also, the call to
lookup_mapping requires an instance string as the second argument (None
will raise an AttributeError).

Attached is example code with the fixes. I'm putting together a short demo
for my team with this functionality and may be able to also send over that
code afterwards.

On Sun, May 15, 2016 at 9:10 PM, Nathan Scott <notifications@xxxxxxxxxx>
wrote:

> Ah, I also just found that test qa/704 is marked as "reserved" & not
> actively being run, so it may well become healthy with these fixes &
> provide the coverage we need - will take a look.
>
> @taintedkernel <https://github.com/taintedkernel> any other test code you
> send through will still be helpful and used too though, thanks.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/performancecopilot/pcp/pull/92#issuecomment-219344959>
>


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

<Prev in Thread] Current Thread [Next in Thread>