pcp
[Top] [All Lists]

Re: [pcp] pcp updates: qa, docs, icons, libpcp fix

To: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: qa, docs, icons, libpcp fix
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 27 Apr 2016 19:43:26 -0400 (EDT)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <572148F4.3060304@xxxxxxxxxx>
References: <1047346353.43497833.1461743562627.JavaMail.zimbra@xxxxxxxxxx> <572148F4.3060304@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: SBNH9WLOsY4gYfp2FziQW98fLem6cg==
Thread-topic: pcp updates: qa, docs, icons, libpcp fix

----- Original Message -----
> On 04/27/2016 05:52 PM, Nathan Scott wrote:
> > Changes committed to git://git.pcp.io/pcp.git master
> ..
> I reviewed the changes to context.c, looks good - taking an extra ref
> like that for (potentially) all contexts could be a pretty hairy leak
> and I'm surprised we've not noticed it before.

Thanks Mark, and yep, it's surprising noone ever came across it before.

> I think you can also break out of the inner loop once we've detected
> that the ports are not the same, as in the attached patch.

Looks good to me - we should possibly start saving up patches like this
for next release, given we are so close (tomorrow)?

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>