Changes committed to git://git.pcp.io/pcp.git master
Nathan Scott (2):
pcp-collectl: handle missing network.interface.in.compressed metric
build: initial version of rpm packaging for Parfait
Lukas Berk (1):
qa/1069 - adjust filter to account for AEST
build/rpm/parfait.spec | 73 +++++++++++++++++++++++++++++++++++++++
qa/1069 | 3 +
src/pcp/collectl/pcp-collectl.py | 34 ++++++++++--------
3 files changed, 96 insertions(+), 14 deletions(-)
commit d88850099c498154f5e268e8ab347bf072a429ff
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Apr 8 13:20:47 2016 +1000
build: initial version of rpm packaging for Parfait
Will become invoked via Makepkgs over time, but at this stage it
is standalone as we get up-and-stumbling.
commit 1efc4cc21dfb9ca2ef142272cdf262420102e46b
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Apr 8 09:26:14 2016 +1000
pcp-collectl: handle missing network.interface.in.compressed metric
Ken found qa/709 fails on MacOSX due to network metrics differences
on that platform when compared to Linux, leading to:
> ! Traceback (most recent call last):
> ! File "/usr/local/bin/pmcollectl", line 9, in <module>
> ! ssx.print_line()
> ! File "/usr/local/bin/pmcollectl", line 9, in print_line
> ! self.print_verbose()
> ! File "/usr/local/bin/pmcollectl", line 9, in print_verbose
> ! sum(self.ss.get_metric_value('network.interface.in.compressed')),
> ! TypeError: 'int' object is not iterable
He diagnosed root cause to: "It appears that get_metric_value() is
returning a scalar value of 0 when values are not available for the
metric ... this is sort of a problem when the caller wraps this in
sum(...) because scalar 0 is not iterable.".
This commit provides a reworking of the extraction of these metrics.
Longer-term it would be good to move away from pmsubsys and its Linux
specific (arch-specific too with kernel.percpu.interrupts) hard-coded
metric lists, but this should resolve the QA failure in the interim.
commit 9e73c28192df803fe3a627b77e8d4072c3e5e1a9
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Tue Apr 5 10:45:08 2016 -0400
qa/1069 - adjust filter to account for AEST
The current archive filter only accounts for AEDT-11, which was failing
now that standart time is in effect (AEST-10).
|