I've pushed this, although test 842 appears to have a time zone issue.
The actual times differ for me by 14 hours which I believe is the
current difference between my time zone and Mark's.
------------------------------------------------------------------------------------------
Changes committed to git://git.pcp.io/pcp master
Mark Goodwin (15):
config: install a global derived metrics config directory with
iostat.conf
docs: clarify pmchart -geometry and -g flags (former is for
display geometry)
pmchart: fix an autoscale bug when loading a view in archive mode
libpcp: load global derived metrics config by default
pmchart: add Iostat view using disk metrics and derived iostat
metrics
packaging: packaging for global derived metrics configs
libpcp: PCP_DERIVED_CONFIG=="" disables loading derived metrics
qa: updates to 'derive' group tests for global derived metrics
pmiostat: improve time delta calculation
qa/common - set PCP_DERIVED_CONFIG to an empty string
pmchart - split out Iostat view to SD, DM and MD
derived metrics: add derived iostat metrics for disk.md
docs - pmiostat man page, mention extra default precision for
avgrq-sz and avgqu-sz
qa - updates for new pmiostat -P precision flag.
qa - extend 842 to check reporting for pmiostat -P precision
Nikhil (1):
Commit for bz 1297498.
build/rpm/fedora.spec | 2
debian/pcp-conf.dirs | 1
debian/pcp-conf.install | 1
man/man1/pmchart.1 | 11
qa/1099.out | 16
qa/225 | 4
qa/246 | 4
qa/247 | 4
qa/249 | 4
qa/256 | 4
qa/370 | 5
qa/509 | 5
qa/536.out | 16
qa/810.out | 3828
+++++++++++++++++++++---------------------
qa/842 | 10
qa/842.out | 136 +
qa/969 | 4
qa/common | 1
src/GNUmakefile | 1
src/derived/GNUmakefile | 33
src/derived/iostat.conf | 49
src/libpcp/src/derive.c | 29
src/pcp/iostat/pcp-iostat.1 | 15
src/pcp/iostat/pcp-iostat.py | 77
src/pmchart/groupcontrol.cpp | 11
src/pmchart/pmchart.cpp | 3
src/pmchart/sampling.cpp | 5
src/pmchart/views/GNUmakefile | 5
src/pmchart/views/Iostat | 88
src/pmchart/views/Iostat.DM | 32
src/pmchart/views/Iostat.MD | 32
31 files changed, 2396 insertions(+), 2040 deletions(-)
Details ...
commit b536b113c16a61a5d0dfc260d73c7842ac1be13f
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Mar 29 17:31:44 2016 +1100
qa - extend 842 to check reporting for pmiostat -P precision
modified: qa/842
modified: qa/842.out
commit f12bced41dbe934ca14d790d79c927cda9f26675
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Mar 29 17:13:20 2016 +1100
qa - updates for new pmiostat -P precision flag.
The pmiostat report format changed slightly with the -P flag defaulting
to 2 decimals, so remake tests in the 'pmiostat' group. i.e.
qa/1099.out,
qa/536.out, qa/810.out and a minor tweak for qa/842 and qa/842.out
commit 0325f568b4a8ddfebbc80f84d0d0894088434f81
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Mar 29 17:08:49 2016 +1100
docs - pmiostat man page, mention extra default precision for
avgrq-sz and avgqu-sz
avgrq-sz and avgqu-sz fields are reported with N+1 decimals because
they're
usually small values.
commit 50a47b1be7d3323824a24bac1b01e733310f6408
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Fri Mar 25 11:22:32 2016 +1100
derived metrics: add derived iostat metrics for disk.md
This adds iostat derived metrics for disk.md devices, complementing
similar derived metrics based on disk.dev and disk.dm. These are
used by the new pmchart view 'Iostat.MD'.
commit fdf0d364956a227c3bc3c20447a201e07a2633cd
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Fri Mar 25 10:46:36 2016 +1100
pmchart - split out Iostat view to SD, DM and MD
This splits out the Iostat view to Iostat (for SD devices using
disk.dev),
Iostat.DM (for device mapper logical devices using disk.dm) and
Iostat.MD
(for logical multiple devices, using disk.md metrics).
modified: src/pmchart/views/GNUmakefile
modified: src/pmchart/views/Iostat
new file: src/pmchart/views/Iostat.DM
new file: src/pmchart/views/Iostat.MD
commit 9c42ba123a40c3ebe4671ea404d7cad4ce5c0615
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Fri Mar 25 10:34:22 2016 +1100
qa/common - set PCP_DERIVED_CONFIG to an empty string
Avoid QA fallout whilst I add new filtering for global derived
metrics configs.
commit 237f9b729d18f4ee320c4fd948108fc1932b3882
Author: Nikhil <nkshirsa@xxxxxxxxxx>
Date: Thu Mar 17 10:32:54 2016 +0530
Commit for bz 1297498.
pcp-iostat now takes a -P parameter that specifies the number of
decimal places to display in the output.
commit 77231e5796034eb8482cb2d13a8abb37db90e719
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Thu Mar 17 13:43:16 2016 +1100
pmiostat: improve time delta calculation
reduces the possibility of arithmetic overflow.
No QA updates needed.
commit f68c60427318969196efc006428d8055417c442c
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Mar 15 12:23:00 2016 +1100
qa: updates to 'derive' group tests for global derived metrics
updates qa/225 qa/246 qa/247 qa/249 qa/256 qa/370 qa/509 qa/969
but no new qualified output.
commit d00d400dd591adba8403b97d2705c3bda052ee72
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Mar 15 09:53:51 2016 +1100
libpcp: PCP_DERIVED_CONFIG=="" disables loading derived metrics
Also add a comment explaining the three use-cases:
If PCP_DERIVED_CONFIG is NOT set, then by default we load global
derived configs from the directory $PCP_VAR_DIR/config/derived.
If PCP_DERIVED_CONFIG is set to a zero length string, then don't
load any derived metrics definitions.
Else if PCP_DERIVED_CONFIG is set then load user-defined derived
metrics from one or more files or directories separated by ':'.
commit b83ef983a98979528a3d70736c0dc3c6677075ce
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 22:05:16 2016 +1100
packaging: packaging for global derived metrics configs
Add new dir PCP_VAR_DIR/config/derived and config file iostat.config
to the pcp-config package.
modified: build/rpm/fedora.spec
modified: debian/pcp-conf.dirs
modified: debian/pcp-conf.install
commit 7a4d099ce75c035c701e153bd3bfedbdcd61f3e0
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 21:57:32 2016 +1100
pmchart: add Iostat view using disk metrics and derived iostat metrics
This is a new multi-tabbed view showing disk and device-mapper traffic
and most of the traditional iostat metrics. Some of these metrics are
derived, see /var/lib/pcp/config/derived/iostat.conf.
modified: src/pmchart/views/GNUmakefile
new file: src/pmchart/views/Iostat
commit 5d5620645415100a4734d379f111b179c25267d6
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 17:41:05 2016 +1100
libpcp: load global derived metrics config by default
If PCP_DERIVED_CONFIG is NOT defined in the environment, then
__dminit()
now loads derived configs from $PCP_VAR_DIR/config/derived by default.
This follows on from previous commit 689c031ca6f5, where we now ship
an iostat.config.
A follow-up change will move the global derived config directory and
iostat.config into the pcp-conf package (currently in pcp base
package).
Also, some QA changes to follow.
commit 0b91a221b8187f11d7c1dd05a222ab3f94f63d35
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 17:26:33 2016 +1100
pmchart: fix an autoscale bug when loading a view in archive mode
Fix an issue in pmchart when loading a view in archive mode, autoscale
isn't properly performed until a pmtime event is received (was
initially
fixed scale at 0 .. 1000). Also improves console diagnostics in related
areas of code. Fix is in GroupControl::adjustArchiveWorldViewForward().
commit df5ec5921a8dab639530d939fb43382d18921305
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Wed Mar 9 17:17:46 2016 +1100
docs: clarify pmchart -geometry and -g flags (former is for display
geometry)
commit 689c031ca6f5db455cce6aab8f145eb5b8029223
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Mar 7 15:23:56 2016 +1100
config: install a global derived metrics config directory with
iostat.conf
Installs a global derived metrics config dir
$PCP_VAR_DIR/config/derived
along with iostat.conf (containing iostat derived metrics definitions).
modified: src/GNUmakefile
new file: src/derived/GNUmakefile
new file: src/derived/iostat.conf
|