----- Original Message -----
> I have a couple of QA failures (qa/1031) ...
>
> Thread 1 terminated abnormally: Can't locate object method "sprint_job_info"
> via package "Slurm" at pmdaslurm.pl line 152.
>
I think this one's resolved by commit e1bd80de5e ... ? (Martins, is there
a better way to fix it than that? i.e. with some additional test data?)
> and
>
> This Perl not built to support threads
> Compilation failed in require at pmdaslurm.pl line 26.
> BEGIN failed--compilation aborted at pmdaslurm.pl line 26.
>
> Now in both cases, I don't want to make the test work (that seems pretty
> pointless), but I'd like guidance on the construction of a suitable _notrun
> guard.
Something like this might do the trick ...
diff --git a/qa/1031 b/qa/1031
index 8f4f628..f55b410 100755
--- a/qa/1031
+++ b/qa/1031
@@ -16,6 +16,9 @@ echo "QA output created by $seq"
[ -d $PCP_PMDAS_DIR/slurm ] || _notrun "slurm PMDA directory is not installed"
perl -e "use PCP::PMDA" >/dev/null 2>&1
[ $? -eq 0 ] || _notrun "perl PCP::PMDA module not installed"
+perl -e "use threads::shared" >/dev/null 2>&1
+[ $? -eq 0 ] || _notrun "perl threads::shared module not installed"
+
status=1 # failure is the default!
$sudo rm -rf $tmp.* $seq.full
cheers.
--
Nathan
|