On Tue, Mar 15, 2016 at 05:31:05PM -0400, Nathan Scott wrote:
>
>
> ----- Original Message -----
> > On Mon, Mar 14, 2016 at 05:53:31PM -0400, Nathan Scott wrote:
> > > ----- Original Message -----
> > > > [...]
> > > > I see that a configuration file PCP_PMDAS_DIR/elasticsearch/es.conf is
> > > > parsed by the PMDA. I was thinking that it would be possible to add a
> > > > new variable, something like $all_node_stats. It would default to false,
> > > > so only metrics from localhost would be fetched. It could be set true by
> > > > that configuration file.
> > >
> > > Good solution, that'd work well.
> >
> > I am planning on doing this unless you say otherwise. I like the
> > approach you're suggesting, but I don't want to break
> > backwards-compatibility unless I'm explicitly told that it's OK.
>
> Yep, good call - go for it. Thanks Alec.
>
Patch attached below. It's been tested with ES 1.7.4 with the new
variable, $all_node_stats, set to 0 and to 1. Default is 0.
The removal of "?all" from the URL does not change behavior at all.
Thanks for all the guidance.
Alec
pmda_es_local.patch
Description: Text Data
|