pcp
[Top] [All Lists]

Re: [pcp] elasticsearch PMDA question

To: Alec Ten Harmsel <alec@xxxxxxxxxxxxxxxxxx>
Subject: Re: [pcp] elasticsearch PMDA question
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 14 Mar 2016 17:53:31 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <20160314212939.GA4200@greenbeast>
References: <20160314141105.GA1513@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <941490186.30277739.1457987906285.JavaMail.zimbra@xxxxxxxxxx> <20160314212939.GA4200@greenbeast>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 7eFPidsaRaNN3HACCxmUKcoaABNn4w==
Thread-topic: elasticsearch PMDA question

----- Original Message -----
> [...]
> I see that a configuration file PCP_PMDAS_DIR/elasticsearch/es.conf is
> parsed by the PMDA. I was thinking that it would be possible to add a
> new variable, something like $all_node_stats. It would default to false,
> so only metrics from localhost would be fetched. It could be set true by
> that configuration file.

Good solution, that'd work well.

> Your solution is fine too; I'm new to PCP, so I will be glad to patch it
> in whichever way fits best with the project. Is your solution just
> leaving as is, but replicating the "elasticsearch.nodes" metric tree to
> something like "elasticsearch.local_node" so old behavior is preserved
> and the new behavior is added?
> 

I was suggesting to rename elasticsearch.nodes.* to elasticsearch.node.*
and adjust the refresh logic accordingly.  Either approach sounds fine to
me though.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>