On Sat, Feb 20, 2016 at 06:45:14AM +1100, Ken McDonell wrote:
> Welcome to the list Alec.
>
Thanks Ken.
>
> > I am planning on patching this for our elasticsearch cluster; is it
> > possible to get this work accepted upstream? Right now, I'm planning
> > on copying the elasticsearch PDMA to elasticsearch2, so that they can
> > coexist.
>
> We're happy to accept contributions and merge 'em, so that's not likely to
> be an issue.
Cool. I am assuming you would like all changes to be based of the master
branch, right?
> Rather than replicating the PMDA (especially if the bulk of the
> functionality is the same) we'd prefer to see a software engineering
> approach where the PMDA probes the source of the data, determines which
> version is currently running out there, and adjusts its behaviour
> accordingly. This may not be possible in some cases, but most commonly this
> is possible.
>
> The PMDA then supports the union of one or more versions of the external
> data source (ES in this case) and will continue to work even if that
> external source is subsequently upgraded.
Alright, I will definitely go in this direction then. I am also slightly
mistaken; I thought my team was/is running ES 2, but we are still on 1.7
(issue still exists, of course - the joys of an unversioned REST API).
In addition to the URL changes, the JSON data that is returned has also
changed, so this will probably require a few more days.
> If there are additional metrics that may or may not be present, then setting
> the metric type to PM_TYPE_NOSUPPORT in the pmDesc structure indicates that
> the associated metric is missing (today).
>
> Instance domains are dynamic, so if the available instances of a metric
> change between versions of the external data source then this is reflected
> directly in the members of the associated instance domain.
Good to know, thanks.
> If you have further questions, this is the right forum to ask them.
>
> Good luck.
>
Thanks, my perl is a bit rusty.
Alec
|