pcp
[Top] [All Lists]

pmrep: adjust exit codes

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: pmrep: adjust exit codes
From: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue, 16 Feb 2016 22:27:49 +0200
Delivered-to: pcp@xxxxxxxxxxx
Organization: Red Hat
Reply-to: Marko Myllynen <myllynen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
Hi,

Some pmrep error exit codes didn't match native PCP tools nor
standard GNU utilities, adjust the few cases accordingly.

---
 src/pmrep/pmrep.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/pmrep/pmrep.py b/src/pmrep/pmrep.py
index 169ba7c..fd3d0ee 100755
--- a/src/pmrep/pmrep.py
+++ b/src/pmrep/pmrep.py
@@ -1371,11 +1371,14 @@ if __name__ == '__main__':
 
     except pmapi.pmErr as error:
         sys.stderr.write('%s: %s\n' % (error.progname(), error.message()))
+        sys.exit(1)
     except pmapi.pmUsageErr as usage:
         usage.message()
+        sys.exit(1)
     except IOError as error:
         if error.errno != errno.EPIPE:
             sys.stderr.write("%s\n" % str(error))
+            sys.exit(1)
     except KeyboardInterrupt:
         sys.stdout.write("\n")
         P.finalize()

Thanks,

-- 
Marko Myllynen

<Prev in Thread] Current Thread [Next in Thread>
  • pmrep: adjust exit codes, Marko Myllynen <=