Hi,
On 2016-02-11 02:00, Nathan Scott wrote:
> ----- Original Message -----
>>
>> Turns out adding derived metrics support to zbxpcp is trivial.
>>
>> Based on comments from Ken yesterday I think we can ignore errors from
>> pmLoadDerivedMetrics, if the configuration file is malformed then
>> messages will be logged into the zabbix-agent log file.
>>
>> Update the man page accordingly. The file name is quite a name monster,
>
> (seems OK to me - leaves no doubt in the mind of the reader as to what it
> is for, anyway)
>
>> please feel free to adjust if you can come up with something better.
>>
>> A small CodingStyle fixlet included as a bonus as well.
>
> Looks good - warrants a tweak to qa/1067 to regression test it?
Metrics with instances wouldn't work if the style fix would break things
so I think we're ok in that sense but qa/1067 may need a bit of other
kind of tweaking, I'm seeing:
1067 - output mismatch (see 1067.out.bad)
123,125c123,125
< pcp.sample.dynamic.counter[one] VALUE
< pcp.sample.dynamic.discrete[one] VALUE
< pcp.sample.dynamic.instant[one] VALUE
---
> pcp.sample.dynamic.counter[1] VALUE
> pcp.sample.dynamic.discrete[1] VALUE
> pcp.sample.dynamic.instant[1] VALUE
So the results depend on the contents of the
/var/lib/pcp/pmdas/sample/dynamic.indom file (and that it actually
exists, the failure is different it doesn't). Do you think it's
worthwhile to keep these metrics as part of 1067? If so, how to make the
test tolerant to missing / different dynamic.indom files?
Thanks,
--
Marko Myllynen
|