pcp
[Top] [All Lists]

Re: [PATCH v3 1/3] perfevent_pmda: Add extension for perf derived events

To: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 1/3] perfevent_pmda: Add extension for perf derived events
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun, 14 Feb 2016 20:09:07 -0500 (EST)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <56BE6E0D.6050101@xxxxxxxxxxxxxxxxxx>
References: <1455060499-14670-1-git-send-email-hemant@xxxxxxxxxxxxxxxxxx> <1779243884.20121961.1455156620367.JavaMail.zimbra@xxxxxxxxxx> <56BE6E0D.6050101@xxxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 1we+3hBpoA8Q7AOOh3ETcDPTCZTwxw==
Thread-topic: perfevent_pmda: Add extension for perf derived events
Hi Hemant,

----- Original Message -----
> [...]
> > One solution might be to add a metric permanently below that point,
> > that is instantiated both with and without derived perfevent counts
> > e.g. perfevent.derived.active (mirror the existing perfevent.active)
> > - a count of #derived metrics - zero valued in the default case.
> 
> Right. Sent a patch to add a metric perfevent.derived.active and
> that should fix the warning.
> http://www.pcp.io/pipermail/pcp/2016-February/009610.html
> 
> Thanks for the suggestion!

No problem, it works nicely here and fixes the issue.  I think this new
metric may need some help text though?  Not sure how best to add that in
with the scheme used, so I'll leave that for you too, if thats OK?  Taa.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>