pcp
[Top] [All Lists]

Re: [PATCH v3 1/3] perfevent_pmda: Add extension for perf derived events

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [PATCH v3 1/3] perfevent_pmda: Add extension for perf derived events
From: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>
Date: Sat, 13 Feb 2016 05:13:09 +0530
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1779243884.20121961.1455156620367.JavaMail.zimbra@xxxxxxxxxx>
References: <1455060499-14670-1-git-send-email-hemant@xxxxxxxxxxxxxxxxxx> <1779243884.20121961.1455156620367.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
Hi Nathan,

On 02/11/2016 07:40 AM, Nathan Scott wrote:
Hi Hemant,

----- Original Message -----
This patch gives the ability to perfevent agent to monitor derived
[...]
I've found one small issue with this just now - when we have no newly
derived metrics, we can see this...

$ pminfo -v perfevent
perfevent.derived: pmLookupDesc: Unknown or illegal metric identifier

I guess this is because there's nothing handling that (dynamic pmns)
node when no derived metrics are configured.

One solution might be to add a metric permanently below that point,
that is instantiated both with and without derived perfevent counts
e.g. perfevent.derived.active (mirror the existing perfevent.active)
- a count of #derived metrics - zero valued in the default case.

Right. Sent a patch to add a metric perfevent.derived.active and
that should fix the warning.
http://www.pcp.io/pipermail/pcp/2016-February/009610.html

Thanks for the suggestion!

cheers.

--
Nathan


--
Thanks,
Hemant Kumar

<Prev in Thread] Current Thread [Next in Thread>