pcp
[Top] [All Lists]

pcp updates - fix pcp-iostat QA issues and use SIGPIPE SIG_DFL

To: pcp <pcp@xxxxxxxxxxx>
Subject: pcp updates - fix pcp-iostat QA issues and use SIGPIPE SIG_DFL
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Thu, 11 Feb 2016 16:01:43 +1100
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
This fixes the QA issues reported by Ken on older python versions
(e.g. RHEL6 / python-2.66). Also: use SIG_DFL SIGPIPE handler to
avoid the unwanted socket.error exceptions on SIGPIPE.

pmiostat QA now passes on f23 with python2 and python3, and also on RHEL6
with python 2.66 (I could repro the issues Ken reported on RHEL6 but not on f23)


Changes committed to git://git.pcp.io/mgoodwin/pcp master

commit 2ad730b4a58e30a0ae14d5d8248d918d4688019d
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Thu Feb 11 15:49:02 2016 +1100

    pmiostat: use SIG_DFL to ignore SIGPIPE and avoid socket.error exceptions
Python installs a sigpipe handler and throws a socket.error exception
    on broken pipe - override this with a SIGPIPE SIG_DFL handler to avoid
    the unwanted exceptions.

commit 83b7b4fff6580d924073968cb8a5b717d329eb16
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Thu Feb 11 14:56:03 2016 +1100

    pmiostat: correctly use a class instance of IostatOptions to check args
Use an instance of IostatOptions to check args. This fixes a coding issue
    with older python versions (e.g. python 2.6.6 on RHEL6), and QA breakage.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates - fix pcp-iostat QA issues and use SIGPIPE SIG_DFL, Mark Goodwin <=