pcp
[Top] [All Lists]

Re: [pcp] zbxpcp: add derived metrics support

To: Marko Myllynen <myllynen@xxxxxxxxxx>
Subject: Re: [pcp] zbxpcp: add derived metrics support
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 10 Feb 2016 19:00:28 -0500 (EST)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <56BAF517.4030300@xxxxxxxxxx>
References: <56BAF517.4030300@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 6atqutpVZ7gfhmr0rjRhSZd2NnXfvw==
Thread-topic: zbxpcp: add derived metrics support

----- Original Message -----
> Hi,
> 
> Turns out adding derived metrics support to zbxpcp is trivial.
> 
> Based on comments from Ken yesterday I think we can ignore errors from
> pmLoadDerivedMetrics, if the configuration file is malformed then
> messages will be logged into the zabbix-agent log file.
> 
> Update the man page accordingly. The file name is quite a name monster,

(seems OK to me - leaves no doubt in the mind of the reader as to what it
is for, anyway)

> please feel free to adjust if you can come up with something better.
> 
> A small CodingStyle fixlet included as a bonus as well.
> 

Looks good - warrants a tweak to qa/1067 to regression test it?

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>