pcp
[Top] [All Lists]

Re: [pcp] pcp updates: pmclient python version fixes

To: Ken McDonell <kenj@xxxxxxxxxxx>
Subject: Re: [pcp] pcp updates: pmclient python version fixes
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun, 31 Jan 2016 02:52:21 -0500 (EST)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <20160131071613.A14D5A0583@kenj>
References: <20160131071613.A14D5A0583@kenj>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: t9qyG324emz1laEPuaiCMwCnpX/4eg==
Thread-topic: pcp updates: pmclient python version fixes
Hi Ken,

I've merged with our overlapping changes sorted out (further
review would still be good though).

thanks.


----- Original Message -----
> With these changes, qa/056 and qa/073 pass on SP and MP
> machines.
> 
> Frank, could you please review the code changes?
> 
> Changes committed to git://git.pcp.io/kenj/pcp master
> 
> Ken McDonell (2):
>       src/pmclient/pmclient_fg.python: fix logic errors
>       qa/073: new .out after python pmclient fixes
> 
>  qa/073.out                      |    1 +
>  src/pmclient/pmclient_fg.python |   12 ++++++------
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> Details ...
> 
> commit 4df8c101a038585257fa4bd102828dd5e444d365
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Sun Jan 31 18:05:59 2016 +1100
> 
>     qa/073: new .out after python pmclient fixes
> 
> commit ad122e27982fa9c6b92fe08f16d059a297322c48
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Sun Jan 31 18:03:23 2016 +1100
> 
>     src/pmclient/pmclient_fg.python: fix logic errors
>     
>     1. loop iteration was wrong ... with -s N it was quitting one iteration
>        too soon
>     2. the conditional logic for ncpu == 1 was just plain wrong
> 

<Prev in Thread] Current Thread [Next in Thread>