pcp
[Top] [All Lists]

Re: [pcp] pmrep: extend QA

To: Marko Myllynen <myllynen@xxxxxxxxxx>
Subject: Re: [pcp] pmrep: extend QA
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 28 Jan 2016 18:15:19 -0500 (EST)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <56AA8905.5080906@xxxxxxxxxx>
References: <56A920F5.3010300@xxxxxxxxxx> <292901872.15281854.1453959343293.JavaMail.zimbra@xxxxxxxxxx> <56AA8905.5080906@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: njKmvxe78h0lQ1w34OLrmBBxua05Lw==
Thread-topic: pmrep: extend QA

----- Original Message -----
> [...]
> The second one is that, as you perhaps noticed,

Yep, these test output differences were what triggered looking into -z.

> your 1069.out update
> changed the timestamps for the test case, you see 20:36:45 but I see
> 13:36:45 here so the test is now failing for me.

Yeah thats definitely not right then - the idea was to have determinism
from -z use -- I think the python tzset from your patch is probably the
subtle piece I missed, keeping the PCP and python date tz in sync.

> I remember I used surprisingly lot of time with write_ext_header() when
> I originally wrote it but seems that it's still not working optimally.
> 
> What do you think of the patch below?

Looks good and passing for me also now - thanks Marko.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>