pcp
[Top] [All Lists]

pcp updates: qa, pmdavmware

To: pcp@xxxxxxxxxxx
Subject: pcp updates: qa, pmdavmware
From: Lukas Berk <lberk@xxxxxxxxxx>
Date: Mon, 25 Jan 2016 16:43:30 -0500
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Hi,

Changes committed to git://git.pcp.io/lberk/pcp master

If anybody has access to vmware host with the required api's to test my
changes, it would greatly appreciated.  Unfortunately there is no qa for
this pmda, so the only thing I have to go on is the report that this
fixed the user's issue on irc.  It appears the api's have changed
slightly in how it handles options.

Lukas Berk (3):
      qa/983 update output
      Update Opts:: usage in pmdavmware.pl
      qa/983 - ensure pmcd has stopped before restarting

 qa/983                         |    1 +
 qa/983.out                     |    1 -
 src/pmdas/vmware/pmdavmware.pl |   13 +++++++------
 3 files changed, 8 insertions(+), 7 deletions(-)

Details ...

commit 572c8f07ace3def86629603d6d2eeb4494de0ac6
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date:   Mon Jan 25 14:39:52 2016 -0500

    qa/983 - ensure pmcd has stopped before restarting
    
    follow up to faca8fc, adding _wait_pmcd_end to the cleanup routine to
    ensure there isn't a race condition between the pmsignal and pcp restart

commit 9a4c39691bc124a9b61b4c6663ec2aeaeb0b0027
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date:   Fri Jan 22 16:29:22 2016 -0500

    Update Opts:: usage in pmdavmware.pl
    
    After some discussions on pcp.freenode.net, it seemed that pmdavmware's
    usage of the Opts methods are (were?) no longer valid.  This patch
    appeared to fix the pmda startup issue experienced by the user.

commit faca8fccc74c7406509be40a716f7025182ff3d2
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date:   Fri Jan 22 16:25:51 2016 -0500

    qa/983 update output
    
    pmsignal should already have killed the pmcd process.  Drop the 'Waiting
    for pmcd to terminate ...' output produced by the pcp restart from the 
output.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: qa, pmdavmware, Lukas Berk <=