| To: | Mark Goodwin <mgoodwin@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [pcp] pcp update: fetchgroups v4: with event-field support |
| From: | Nathan Scott <nathans@xxxxxxxxxx> |
| Date: | Thu, 21 Jan 2016 02:23:06 -0500 (EST) |
| Cc: | Marko Myllynen <myllynen@xxxxxxxxxx>, "Frank Ch. Eigler" <fche@xxxxxxxxxx>, pcp@xxxxxxxxxxx |
| Delivered-to: | pcp@xxxxxxxxxxx |
| In-reply-to: | <56A0569D.2000606@xxxxxxxxxx> |
| References: | <20160102052522.GB13026@xxxxxxxxxx> <56931A33.8000603@xxxxxxxxxx> <1222601165.10793219.1453171955611.JavaMail.zimbra@xxxxxxxxxx> <20160119152928.GB13054@xxxxxxxxxx> <2039224745.11117897.1453237884814.JavaMail.zimbra@xxxxxxxxxx> <20160120174347.GA10695@xxxxxxxxxx> <152148245.11905438.1453332764634.JavaMail.zimbra@xxxxxxxxxx> <56A0569D.2000606@xxxxxxxxxx> |
| Reply-to: | Nathan Scott <nathans@xxxxxxxxxx> |
| Thread-index: | k0thGOYcSTmZHs6gHg/SqBCamZCXgg== |
| Thread-topic: | pcp update: fetchgroups v4: with event-field support |
Hey Mark, ----- Original Message ----- > > [...] > > It makes most sense to me to have the sentinel values as: empty string, > > NaN (as you have), and all-bits-set for integers (ie -1). > > perhaps -2^31, which is kind of the same as a float NaN and better than zero > IMO : Yeah maybe - we are dealing with a pmAtomValue here though so it's possibly handy to have the same value for 32bit as 64bit - which all-bits-set gives. Then our hypothetical lazy programmer can interchange whatever printf format they like for 32/64, and it will report something sensible. Its also easier to document on the man page. ;^) For the initial merge, I've gone with all-bits-set. If there's still strong opinion about some other value, please continue discussing - it's relatively easy to update before next release (end of next week), and those of us doing regular QA need to begin getting wider exposure now, before the next largish merge (Lukas' pmdaroot updates, end of tomorrow). cheers. -- Nathan |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [pcp] pcp update: fetchgroups v4: with event-field support, Mark Goodwin |
|---|---|
| Next by Date: | pcp updates: fetchgroups, Nathan Scott |
| Previous by Thread: | Re: [pcp] pcp update: fetchgroups v4: with event-field support, Mark Goodwin |
| Next by Thread: | Fwd: PMDAs for lm_sensors, HDD SMART monitoringâ, David O'Shea |
| Indexes: | [Date] [Thread] [Top] [All Lists] |