| To: | performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [pcp] Celanup memory when initializing pthread mutex (#61) |
| From: | Ken McDonell <notifications@xxxxxxxxxx> |
| Date: | Wed, 20 Jan 2016 14:04:48 -0800 |
| Delivered-to: | pcp@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1453327488; bh=nDDn+omg2DwN51I1VceegKBbB8xizVbCYhzTL0qzSSQ=; h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=I/8OXgMdbk2CZlncDufHHiNemH4vYMNiaYWvfXd9SS/vd5bcixO6HOtaoutqw50IY t8nxctOemqbfhKlqpKj1mVkc0Sif7uglzi/bNqvS6Lo1JM9CoJK/QbBpqBn876/jC5 X/lISuCWkYxNfrRvAY3YI5RhvTB1MKBB/9TRSPx0= |
| In-reply-to: | <performancecopilot/pcp/issues/61@xxxxxxxxxx> |
| List-archive: | https://github.com/performancecopilot/pcp |
| List-id: | performancecopilot/pcp <pcp.performancecopilot.github.com> |
| List-post: | <mailto:reply+00bd08b6708a0ab7de32a7c761d4a3857c6f1ca7d946734892cf0000000112b7c68092a169ce07934c3f@reply.github.com> |
| List-unsubscribe: | <mailto:unsub+00bd08b6708a0ab7de32a7c761d4a3857c6f1ca7d946734892cf0000000112b7c68092a169ce07934c3f@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0Its1ZeBRBfhpoC9VyIsS_F8ghDPPRks5pb_wAgaJpZM4HGeAf> |
| References: | <performancecopilot/pcp/issues/61@xxxxxxxxxx> |
| Reply-to: | performancecopilot/pcp <reply+00bd08b6708a0ab7de32a7c761d4a3857c6f1ca7d946734892cf0000000112b7c68092a169ce07934c3f@xxxxxxxxxxxxxxxx> |
|
Thanks for the patch it is good to see the code being reviewed by fresh eyes. But in these case I don't believe that the destroy is required ... the attr is allocated on the stack and the storage is reclaimed when the block is exited (just after the places where you're suggesting the destroy should be added). I'll close this issue in a couple of days unless there is new information to suggest my analysis is wrong. Cheers, Ken — |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [pcp] Oracle PMDA - sysstat values, Narendra Babu, Nandhita |
|---|---|
| Next by Date: | Re: [pcp] pcp update: fetchgroups v4: with event-field support, Nathan Scott |
| Previous by Thread: | pcp updates: qa cull test code dependent on PCP_VER, PCP_EOE_VER or PCP_PLATFORM == irix, Ken McDonell |
| Next by Thread: | pcp updates: fetchgroups, Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |