pcp
[Top] [All Lists]

Re: [pcp] pmRegisterDerived return values

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, pcp developers <pcp@xxxxxxxxxxx>
Subject: Re: [pcp] pmRegisterDerived return values
From: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue, 19 Jan 2016 12:05:01 +0200
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <569CB7C5.7030803@xxxxxxxxxxxxxxxx>
Organization: Red Hat
References: <569CB025.4070603@xxxxxxxxxx> <569CB7C5.7030803@xxxxxxxxxxxxxxxx>
Reply-to: Marko Myllynen <myllynen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
Hi,

On 2016-01-18 12:00, Ken McDonell wrote:
> On 18/01/16 20:28, Marko Myllynen wrote:
>>
>> In https://bugzilla.redhat.com/show_bug.cgi?id=1286733 two Python PMAPI
>> pmRegisterDerived related issues were reported and they were already
>> fixed but I think we all kind of forgot the bigger picture.
>>
>> Consider this example (from the BZ):
>>
>>          try:
>>              self.context.pmRegisterDerived("foo", "rat(disk.dev.read)")
>>          except:
>>              print self.context.pmDerivedErrStr()
>>
>> Here pmDerivedErrStr returns nothing. Is this expected or should
>> pmDerivedErrStr be improved to return always something understandable in
>> case of errors?
> 
> Looks like a Python wrapper issue ... libpcp and friends get it right it
> would appear.
> 
> kenj@bozo:~/src/pcp/qa$ pminfo -c /tmp/eek foo
> [/tmp/eek:1] Error: pmRegisterDerived(foo, ...) syntax error
>  rat(disk.dev.read)
>     ^
> Error: foo: Unknown metric name
> kenj@bozo:~/src/pcp/qa$ cat /tmp/eek
> foo = rat(disk.dev.read)

Thanks, filed a bug to keep track of this:

https://bugzilla.redhat.com/show_bug.cgi?id=1299806

Cheers,

-- 
Marko Myllynen

<Prev in Thread] Current Thread [Next in Thread>