Changes committed to git://git.pcp.io/pcp.git master
Ken McDonell (4):
src/pmcd/src/pmcd.c: tweak earlier fix for opening log
Revert "src/pmcd/src/pmcd.c: tweak earlier fix for opening log"
src/pmcd/src/pmcd.c: revert the __pmOpenLog() call logic
src/pmcd/src/pmcd.c: just put the __pmOpenLog() call back where it was
Nathan Scott (2):
docs: first round of updates to system CPU performance tutorial
pmchart: small improvements to the vCPU view
man/html/howto.cpuperf.html | 395 +++++++++++++++++++-------------------------
src/pmcd/src/pmcd.c | 66 +++----
src/pmchart/views/vCPU | 6
3 files changed, 210 insertions(+), 257 deletions(-)
commit 46c86fa82011a2c984673c504c5aa6dc07c6709d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Jan 6 18:49:56 2016 +1100
pmchart: small improvements to the vCPU view
Rearrange the order in which some guest metrics appear so
that when CPU and vCPU views used similtaneously they are a
direct visual match (i.e. more clearly showing which metrics
are divided up in the vCPU view when compared to CPU view).
Updated the repeated phrase in the heading for clarity too.
commit 86a3b00805aeca859289696e98e700aa17256373
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Jan 6 18:45:01 2016 +1100
docs: first round of updates to system CPU performance tutorial
commit e1f0995a8e436d56aa7fc42c3045a56c743206b2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jan 6 07:03:49 2016 +1100
src/pmcd/src/pmcd.c: just put the __pmOpenLog() call back where it was
Turns out it needs to be not only after the argument parsing, but also
after the pmcd request port is established (to avoid an accidentally
started second pmcd clobbering the first pmcd's log ... and yes there
is a qa test for this).
So the call is back where it originally was, but with a comment that
tries to explain why, so when my dementia gets worse I won't make the
same blunder again.
Sigh.
commit 58fb2bc57b3844bc2f2963dcf04e6fb6190291f0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jan 6 06:55:37 2016 +1100
src/pmcd/src/pmcd.c: revert the __pmOpenLog() call logic
This change reverts the __pmOpenLog() change in commit
ee2433dcef79ea8f46d81bc92e7e2c088fa0022b back to almost the
way it was ... the call is a little earlier, but after the
argument parsing.
commit f76107a18e9fdad4d6cb705b2654383f3b205ba3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jan 6 06:45:17 2016 +1100
Revert "src/pmcd/src/pmcd.c: tweak earlier fix for opening log"
This reverts commit 35be9defe49dc68b851fc7e2e05a4190e01fbf90.
commit 35be9defe49dc68b851fc7e2e05a4190e01fbf90
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jan 6 06:37:37 2016 +1100
src/pmcd/src/pmcd.c: tweak earlier fix for opening log
Need to explicitly call __pmSetProgname() before calling __pmOpenLog()
because pmProgname is needed in the log file header line. Previously
we were calling __pmOpenLog() after the command line arguments had
been parsed and __pmSetProgname() is called as a side-effect there.
|