pcp
[Top] [All Lists]

pcp updates: put pmcd back the way it was ... nothing to see here, move

To: pcp@xxxxxxxxxxx
Subject: pcp updates: put pmcd back the way it was ... nothing to see here, move along
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed, 6 Jan 2016 07:22:43 +1100
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
Changes committed to git://git.pcp.io/kenj/pcp master

Ken McDonell (3):
      Revert "src/pmcd/src/pmcd.c: tweak earlier fix for opening log"
      src/pmcd/src/pmcd.c: revert the __pmOpenLog() call logic
      src/pmcd/src/pmcd.c: just put the __pmOpenLog() call back where it was

 src/pmcd/src/pmcd.c |   65 ++++++++++++++++++++++++++--------------------------
 1 file changed, 33 insertions(+), 32 deletions(-)

Details ...

commit e1f0995a8e436d56aa7fc42c3045a56c743206b2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Wed Jan 6 07:03:49 2016 +1100

    src/pmcd/src/pmcd.c: just put the __pmOpenLog() call back where it was
    
    Turns out it needs to be not only after the argument parsing, but also
    after the pmcd request port is established (to avoid an accidentally
    started second pmcd clobbering the first pmcd's log ... and yes there
    is a qa test for this).
    
    So the call is back where it originally was, but with a comment that
    tries to explain why, so when my dementia gets worse I won't make the
    same blunder again.
    
    Sigh.

commit 58fb2bc57b3844bc2f2963dcf04e6fb6190291f0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Wed Jan 6 06:55:37 2016 +1100

    src/pmcd/src/pmcd.c: revert the __pmOpenLog() call logic
    
    This change reverts the __pmOpenLog() change in commit
    ee2433dcef79ea8f46d81bc92e7e2c088fa0022b back to almost the
    way it was ... the call is a little earlier, but after the
    argument parsing.

commit f76107a18e9fdad4d6cb705b2654383f3b205ba3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Wed Jan 6 06:45:17 2016 +1100

    Revert "src/pmcd/src/pmcd.c: tweak earlier fix for opening log"
    
    This reverts commit 35be9defe49dc68b851fc7e2e05a4190e01fbf90.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: put pmcd back the way it was ... nothing to see here, move along, Ken McDonell <=