https://bugzilla.redhat.com/show_bug.cgi?id=1295551
Bug ID: 1295551
Summary: some pipe pmda issues
Product: Fedora
Version: 22
Component: pcp
Assignee: nathans@xxxxxxxxxx
Reporter: fche@xxxxxxxxxx
QA Contact: extras-qa@xxxxxxxxxxxxxxxxx
CC: brolley@xxxxxxxxxx, fche@xxxxxxxxxx, lberk@xxxxxxxxxx,
mgoodwin@xxxxxxxxxx, nathans@xxxxxxxxxx,
pcp@xxxxxxxxxxx, scox@xxxxxxxxxx
In pcp-3.10.9-1.fc22.x86_64:
- the pipe pmda is in the core pcp rpm instead of a subrpm
- it does not include an empty /etc/pcp/pipe.conf.d directory, without which
the pmda startup fails
- it should probably include at least a blank pipe.conf file (owned by root!)
so the pmda will at least start (for testing purposes)
- it excludes the pmdapipe man page
- the pmdapipe page does not explain what happens security-wise if there is no
[access] clause
- the pmdapipe page does not explain invocation-parameter quoting rules, such
as for passing metacharacters or embedded spaces
- the sample.conf should have an [access] block that makes it less likely that
someone installing the sample.conf as pipe.conf will thereby give random local
users access to the running-as-root programs therein, since the [access]-less
default appears to be to GRANT access
- installing said sample.conf as pipe.conf, restarting pmcd, then running
# pmval -i bdev_trace pipe.firehose
results in no output; no errors; no log entries; as per strace no attempt to
run the btrace binary; some pmda -Dall suggests internal error -12391 at some
point; because of bug #1229494, one can't strace -Dall effectively
# pmval -i bdev_trace -x "5 BADDEVICE" pipe.firehose
results in no output, even though btrace must have signalled a failure on its
stderr; similarly no log/output if the /usr/bin/btrace program is not installed
at all
# pmval -i bdev_trace -x "5 DEVICE" pipe.firehose
results in output; the [end] flag is set on many of the last lines, so they
don't match up with the single [start]-flagged line at the top; event-flagging
behaviour should be documented in man page
# pmval -i bdev_trace -x "5 DEVICE JUNK JUNK JUNK" pipe.firehose
quietly ignores JUNK; if this is desirable, it should be documented
# pmval -i rw_syscalls -x /dev/null pipe.firehose
results in pmval: store value "/dev/null" failed: Bad input to pmstore
which would be OK if it were to signal that "perf script rw-by-file" errors out
on that input, but that's probably not what it means.
# pmval -Dall -i bdev_trace -x '50 /dev/md0' pipe.firehose
results in a SEGV; valgrind has multiple complaints
- cursory code review shows numerous unchecked strdup() calls; consider at
least assert()ing those against OOM
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=NpCAuS18uk&a=cc_unsubscribe
|