Changes committed to git://git.pcp.io/pcp.git master
Nathan Scott (9):
build: update fedora spec changelog with a missing bz
qa: make test 324 guard against a conflicting shm key
qa: wait longer in 878 for success cases, needed on buildbots
pmrep: install config file to /etc/pcp/pmrep/pmrep.conf
qa: add test to exercise the vmstat section of stock pmrep config
qa: basic regression test for pmrep -R to -T substitution
pmrep: fix divide-by-zero found testing -T/-R transition
docs: fix couple of typos on pmrep man pages
qa: extend net iface filtering in test 581
Marko Myllynen (7):
build: fix git permissions on several pmchart configs
pmrep: improve vmstat example
pmrep: replace -R with -T as nature intended
pmrep: fix labels for metric sets
pmrep: avoid ambiguous config option
pmrep: allow for other values of type keyword in the future
pmrep: fix command line parsing, again
build/rpm/fedora.spec | 3 +
qa/.gitignore | 1
qa/1062 | 34 +++++++++++++++++
qa/1062.out | 12 ++++++
qa/1069 | 2 +
qa/1069.out | 6 +++
qa/324 | 10 +----
qa/324.out | 71 +++++++++++++++++++++++++++++++++++
qa/324.out.1 | 76 --------------------------------------
qa/324.out.2 | 71 -----------------------------------
qa/581 | 1
qa/878 | 12 +++---
qa/878.out | 6 +--
qa/archives/GNUmakefile | 2 -
qa/archives/mk.vmstat.sh | 29 ++++++++++++++
qa/archives/pcp-vmstat.0 |binary
qa/archives/pcp-vmstat.index |binary
qa/archives/pcp-vmstat.meta |binary
src/pmdas/txmon/txmon.c | 2 -
src/pmrep/GNUmakefile | 3 +
src/pmrep/TODO | 7 ++-
src/pmrep/pmrep.1 | 86 +++++++++++++++++++------------------------
src/pmrep/pmrep.conf | 47 ++++++++++++++---------
src/pmrep/pmrep.conf.5 | 33 ++++++----------
src/pmrep/pmrep.py | 64 ++++++++++++++++++--------------
25 files changed, 297 insertions(+), 281 deletions(-)
commit 7878fede8b949c1bb4b781579ae3be09af0a5c09
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 17:23:45 2015 +1100
qa: extend net iface filtering in test 581
commit 86c916d7048de987d8e7dd04b7b1a50e2330ecfd
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue Dec 15 15:13:18 2015 +1100
pmrep: fix command line parsing, again
ef4312 tried to address the issue of not being able to provide options
after metrics but it turned out that that route hit the wall elsewhere
(RHBZ#1289912) and it also caused a horrible regression where command
line options did not override configuration file parameters any more.
Revert back to what we had earlier in use for a long time and sort
out things in a more robust fashion after first release as needed.
commit bd53691984d5c759229cbb8ff2b0a28350d62051
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue Dec 15 15:10:05 2015 +1100
pmrep: allow for other values of type keyword in the future
Generalize the metric presentation type by changing the "raw"
keyword to "type" instead and use "raw" instead of "yes" to
denote raw metric type.
commit b1af21f22da69b5bb2f54ba788fe2a20a3d42dd6
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 15:04:08 2015 +1100
docs: fix couple of types on pmrep man pages
commit bb478527b6eb26d36c16d42a4024397f47611bd6
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue Dec 15 15:03:09 2015 +1100
pmrep: avoid ambiguous config option
commit 805ad2a00a74183c1e2dd82a49c41ea0ec782605
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue Dec 15 14:56:20 2015 +1100
pmrep: fix labels for metric sets
Fix the code to match the man page (identifier is not used for anything
except for binding the metrics and specifications together).
A metric specification of "allcache = mem.util.allcache" will now have
mem.util.allcache as default label instead of allcache, this matches
much better with compact form definition and is what the man page says.
Few minor example config tweaks while at it.
commit b6572a1e0106ecbbf01a78a4e9131a792d097605
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 14:45:51 2015 +1100
pmrep: fix divide-by-zero found testing -T/-R transition
Traceback (most recent call last):
File "/usr/bin/pmrep", line 1320, in <module>
P.validate_config()
File "/usr/bin/pmrep", line 587, in validate_config
self.samples = self.runtime / int(self.interval) + 1
Properly fixing the integer-conversion of time is going to
have to wait for next release, and should be done by using
already-debugged shared py module code (like pcp.pmcc - or
at least, not such that its debugged anew for every python
script).
Currently in pmrep, sub-second time use is correct in some
places but not in others - ultimately, all the int() casts
will need to be removed, one way or another.
commit 801e6ca3cbab9aa075ed7ff60df3d20ba3097c54
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 14:33:45 2015 +1100
qa: basic regression test for pmrep -R to -T substitution
commit 2455246a09862fbf62a6dd3e93ed6d72d27a9483
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue Dec 15 14:32:51 2015 +1100
pmrep: replace -R with -T as nature intended
Use pmOptions end time for "runtime" in live mode also, like
other PCP tools. Drop references to "runtime" as a separate
concept in man pages, configs, etc.
commit 1bce929fdbb54ecbb90201c8f89c62461c26a2b9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 13:43:19 2015 +1100
qa: add test to exercise the vmstat section of stock pmrep config
Checks vmstat pmrep output, archive and live modes, in test 1062;
also adds a mk.vmstat.sh to recreate the archive if ever needed.
commit 7ccfda603f06d01d6fda27aa6d2e64d1ff2720a7
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue Dec 15 13:10:02 2015 +1100
pmrep: improve vmstat example
Mark showed how to get real percentages for different CPU usage
categories, update pmrep's vmstat example accordingly.
commit 5700b60bb3bcc4f2ba8b2dbba1159cf08e2ef295
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 12:51:04 2015 +1100
pmrep: install config file to /etc/pcp/pmrep/pmrep.conf
Comment out sample metric in the global section, and add
pmrep.conf to the installed files (pcp-system-tools rpm).
commit acaa5b53e521776a83a1b648b8f94e35b8bd24a9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 11:22:39 2015 +1100
qa: wait longer in 878 for success cases, needed on buildbots
commit c3bd6bf7116e8f99f122f9948662c0b661ea5fbd
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 11:13:48 2015 +1100
qa: make test 324 guard against a conflicting shm key
Add a notrun guard to 324 that verifies the shm key it
will create (via pmdtxmon) does not already exist - this
can cause permissions problems, causing the PMDA to not
start, causing test failure.
commit a56be5652661b1cc53f6c5cc34f3fa4982f46b52
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue Dec 15 10:25:19 2015 +1100
build: fix git permissions on several pmchart configs
commit c82a9b13c5b69b6bb9404b02351000f726f989a7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Dec 15 10:16:26 2015 +1100
build: update fedora spec changelog with a missing bz
|