Hi Marko,
I've pushed through the first big batch of your pmrep changes now. I
think we still need: a version# in the config file (somehow? see my
IRC q from overnight - first line? [options]?), the pmrep.conf.5 man
page (sounds like you have that under control), and the non-options
handling should switch to the pmOption API (relying on another patch
to the API you sent I think - will test+merge shortly). Are there any
other pmrep items before the initial release?
It'd be good to have some more test cases - could you suggest more to
add to 1068 (zabbix-parts) and 1069 (general pmrep)? I must have done
something incorrectly in the derived metrics use (see comments toward
the end of 1069) - can you take a look & spot my error there? Taa.
In terms of the zbxsend module issues, after poking around the python
code you pointed me to (thanks) I think it does make sense to pull it
into pmrep for now - fixing the py3 issues, packaging issues, etc. It
is very small, very simple, and will make life significantly simpler
for both users and us as developers. So I went ahead and did that, as
well as a handful of other small changes - please review 'em & update
as you see fit, thanks!
For future releases, if we can abstract a pmrep API for pcp2xxx tools
I think a pcp2zabbix(1) would make good sense (that bit of zbxsend code
could then live in there, outside of the shared pmrep code). In that
model, I imagine both pmrep and pcp2zabbix as small front-end scripts
(100 lines or so, tops)... but thats something for later, lets get the
core functionality finished off and well-tested now.
cheers.
--
Nathan
|