On 11/25/2015 04:48 PM, Frank Ch. Eigler wrote:
Hi -
I have finally made some progress on the "fetchgroup" api extension
that we had talked about a year ago and then some [1]. It's starting
to come together, and am looking for feedback on design or smaller
issues.
The work is all on git://sourceware.org/git/pcpfans.git fche/fetchgroup .
The core implementation is in libpcp/src/fetchgroup.c; a man page in
man/man3/pmfetchgroup.3 with a sample program (below); and adapts
src/pmmgr and src/pmclient to the api. QA and fixes are coming. The
man page would be a good one to start from. I'd be happy to explain
further.
Hi Frank, I like this API - have a few questions and suggestions. To begin
with, for the case where we make several calls to pmExtendFetchGroup_indom for
several different metrics with the same instance domain and the same fetch
group,
the returned instance domains should match up, right? e.g. for proc metrics,
which are pretty dynamic, that doesn't seem to be happening - but maybe I'm
missing something ...
Here's a test program to demonstrate (this would make a reasonable qa test too
BTW) :
fetchgrouptest.c
Description: Text Data
|