Hi guys,
----- Original Message -----
> [...]
> elasticsearch is not the only PMDA omitted from your build, from the log
> file ...
>
> checking if the mysql PMDA should be included... no
> checking if the postgresql PMDA should be included... no
> checking if the elasticsearch PMDA should be included... no
> checking if the nginx PMDA should be included... no
> checking if the activemq PMDA should be included... no
> ...
> checking if the postfix PMDA should be included... no
Commit 01dd8ff862 picks up all of these except for pmdapostfix.
> I think we have a couple of objectives here ...
>
> 1. On any platform a build from source and install should succeed if
> possible, and in particular any component (PMDAs in this instance, but
> not limited to them) that depends on something that is not universally
> available may conditionally not be built and packaged. This was my
> objective.
*nod*
> 2. On any specific platform, we should expect some set of packages to be
> created. This is especially true of a "distro" build and was the
> problem Lukas ran into.
*nod*
> The configure and pcp.spec.in changes address 1.
>
> Adding BuildRequires to match the configure logic in fedora.spec will
> address 2. for Fedora builds (and possibly RedHat builds, I'm not sure
> how they are done).
(its based on fedora.spec, so things fixed there propagate over time)
> That still leaves 2. as an unsolved issue for all of the non-Fedora (and
> possibly non-RedHat) rpm distros and all of the distros not using rpm.
>
> This sounds like QA fodder, but it is a lot of work to set up and audit
> on-going ... I'm not sure who's sufficiently motivated to volunteer to
> undertake this.
It would be best to fail at build time if bits are missing that are expected.
Hmm, would configure options like --with-pmda-nginx=yes help here? (causing
the build to fail IOW) And explicitly listing the expectations in the distro
package builds. Not sure if this really helps though, cos someone still has
to remember to add the configure options explicitly. Hmm.
> So, I trundled off to see how often the elasticsearch PMDA QA tests are
> run vs notrun ... and there are apparently NO QA tests for this PMDA ...
> grrr!!!
>
Its an older PMDA & hasn't percolated to top of the list yet unfortunately,
nor has anyone hacked on it for awhile. I have a local elasticsearch setup
though, so I can follow up with a basic test unless someone else wants to?
cheers.
--
Nathan
|