| To: | performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [pcp] libpcp: unlock context before returning (#50) |
| From: | Ryan Doyle <notifications@xxxxxxxxxx> |
| Date: | Mon, 09 Nov 2015 13:46:43 -0800 |
| Delivered-to: | pcp@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha1; c=relaxed; d=github.com; h=from:reply-to:to:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=hsyHpM5kmxpQd6aI+ESq+LaqrBo=; b=WQjX513dIADBoZMu H4TuVkE8uJv0RG3h83ueteKMnUylpPTGY+zqP8SSxUYEUJo3lZHrlSqtNvYWG3ui 6UN7eY+4bkCWI4fK+0kSDcvPpoo7IKUCZhTAZfDmvDdBp+2MuE7PpuvkO/YU/AsP q7HSJju6D0wuOPShDEY93b/bQzM= |
| In-reply-to: | <performancecopilot/pcp/pull/50@xxxxxxxxxx> |
| List-archive: | https://github.com/performancecopilot/pcp |
| List-id: | performancecopilot/pcp <pcp.performancecopilot.github.com> |
| List-post: | <mailto:reply+00bd08b6f69624eea00942f4e0ae1b8b55ad45769ee591a592cf000000011258d64392a169ce06e7914e@reply.github.com> |
| List-unsubscribe: | <mailto:unsub+00bd08b6f69624eea00942f4e0ae1b8b55ad45769ee591a592cf000000011258d64392a169ce06e7914e@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0ItqEywIFfwBqY1UyLKaDLdZNFWZBBks5pEQvDgaJpZM4GecmI> |
| References: | <performancecopilot/pcp/pull/50@xxxxxxxxxx> |
| Reply-to: | performancecopilot/pcp <reply+00bd08b6f69624eea00942f4e0ae1b8b55ad45769ee591a592cf000000011258d64392a169ce06e7914e@xxxxxxxxxxxxxxxx> |
|
Hi Ken Its true that its an unlikely code path. I discovered it while in the process of writing Ruby bindings (still a work in progress!). I have test cases for local and archive contexts which test both success and error conditions. If you're interested, I have a WIP branch called — |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | qa/823 failures - sasl authentication, Ken McDonell |
|---|---|
| Next by Date: | pcp updates: qa - small, but important oversight, Ken McDonell |
| Previous by Thread: | Re: [pcp] libpcp: unlock context before returning (#50), Ken McDonell |
| Next by Thread: | pcp updates: qa and libpcp locking (thanks to Ryan Doyle), Ken McDonell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |