Hi,
On 2015-10-29 09:00, Marko Myllynen wrote:
> On 2015-10-29 03:51, Nathan Scott wrote:
>>>
>>> I'm seeing few build issues on RHEL 7.1 with a freshly cloned git tree:
>>>
>>> 1) configure --help says
>>>
>>> --srcdir=DIR find the sources in DIR [configure dir or `..']
>>>
>>> but configure checks for existence of ./VERSION.pcp so either the check
>>> or --srcdir would seem to be outdated (if the point was to support the
>>> srcdir != builddir case). Copying the file to the builddir doesn't help
>>> as configure machinery doesn't create a makefile locally and also make
>>> -f fails. Perhaps srcdir == builddir is expected?
>>
>> I think this is an added-by-default option in configure - AFAIK, noone
>> has ever played with it for PCP builds before. So, dunno, but it would
>> not surprise me if things are not hooked up for a PCP build behind that
>> option. (feel free to hack on it of course)
>
> I think it might be easiest just to drop it to avoid confusion.
this is actually one of the autoconf standard options so not that
trivial to drop it.
>>> 3) make install fails without --with-systemd=no as otherwise the
>>> following is tried (even with something like --prefix=/tmp/foo):
>>>
>>> rm: cannot remove â/usr/lib/systemd/system/pmcd.serviceâ: Permission denied
>>> cp: cannot create regular file â/usr/lib/systemd/system/pmcd.serviceâ:
>>> Permission denied
>>
>> Hmm, not sure what to do about that one - we simply take the path pkg-config
>> gives us for systemd unit files. (see configure.ac line ~687) I'm guessing
>> that doesn't get any --prefix applied to it as a result.
>
> Hmm, I don't like "make install" touching anything outside of --prefix.
Looks like we both missed SYSTEMD_SYSTEMUNITDIR, with it set the unit
files are installed where the user wants.
So starting to look good. After a build I see the following files having
appeared in the tree which are not in .gitignore, perhaps they should be
added there:
# python3-pcp.list
# python3-pcp.list.rpm
# src/pcp/iostat/pcp-iostat.1.gz
Thanks,
--
Marko Myllynen
|