Nathan,
On 10/5/15 9:35 PM, Nathan Scott wrote:
Hi Martins,
----- Original Message -----
----- Original Message -----
Hi,
Commit c683075c3aa39d41d18b2ee35f426c726f7af193 generates errors in
pmda startup for my nfs machines.
I get things like the following:
......
Argument "tcp" isn't numeric in numeric ne (!=) at
/var/lib/pcp/pmdas/nfsclient/pmdanfsclient.pl line 422.
Argument "all" isn't numeric in numeric ne (!=) at
/var/lib/pcp/pmdas/nfsclient/pmdanfsclient.pl line 422.
Argument "tcp" isn't numeric in numeric ne (!=) at
/var/lib/pcp/pmdas/nfsclient/pmdanfsclient.pl line 422.
......
I can take a look next week unless someone gets to it sooner.
I think I see the problem, in that the new checks are not catering
for the case where a value was observed but its a string instead of
a number - I'll get a patch out shortly, thanks Martins.
Does the attached patch help? Not 100% sure about the above theory
any more, because the test code does include string metric checking
and that seems to be working OK for me (even without the attached).
OK, so with the original problem, QA is not failing here either. To see
it, you can create:
PCP_PMDAS_DIR/nfsclient/nfsclient.conf
with the contents:
$MOUNTSTATS_PATH = "/var/lib/pcp/testsuite/nfsclient/mountstats.qa";
and install the pmda. That gives me similar errors in the pmda log as
above.
With your patch, I get in the log:
Log for pmdanfsclient on centos7 started Tue Oct 6 14:20:21 2015
Argument "19 (time, in seconds, since the NFS is mounted)" isn't
numeric in subroutine entry at
/var/lib/pcp/pmdas/nfsclient/pmdanfsclient.pl line 11
34.
Use of uninitialized value $value in string ne at
/var/lib/pcp/pmdas/nfsclient/pmdanfsclient.pl line 423.
Use of uninitialized value in subroutine entry at
/var/lib/pcp/pmdas/nfsclient/pmdanfsclient.pl line 1134.
These may have been my fault and just not reported in the log until your
change, can't remember if I added both these metrics or not. Sorry. One
a bad regex, and the other a typo. Patch attached. But not sure why QA
wasn't catching the initial problem.
So with this patch and your patch, all is working now without error.
Thanks!
Martins
nfsclient.patch
Description: Text Data
|