Martins Innus <minnus@xxxxxxxxxxx> writes:
> I'm seeing some sort of race condition that I haven't been able to
> track down. If you create a bunch of
> /var/lib/pcp/pmdas/<pmda>/.NeedInstall files and then restart pmcd,
> sometimes, but not always, all the pmda/pmcd logs are gone, and only
> the .prev versions remain [...]
> As far as I can tell, when you have more than one .NeedInstall file,
> the pmcd restart process gets nested/recursive/happens multiple times
> or something. This is on Centos 7 and current git pcp.
That's a very good point. /etc/rc.d/pmcd == /usr/share/pcp/lib/pmcd
_pmda_setup() is run in the background, just after the initial pmcd
process is started. Those _pmda_setup()s can call to multiple pmda
Install scripts in some sequence. Some of those Install scripts
restart pmcd via the same rc script, so nestedness and concurrency
is easily possible.
Perhaps the NeedInstall machinery should be removed entirely from
the pmcd rc script, and let the rpm %post-install (or equivalents)
handle them.
- FChE
|