| To: | Martins Innus <minnus@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [pcp] perfevent metric name changes |
| From: | Nathan Scott <nathans@xxxxxxxxxx> |
| Date: | Tue, 22 Sep 2015 03:57:10 -0400 (EDT) |
| Cc: | pcp@xxxxxxxxxxx |
| Delivered-to: | pcp@xxxxxxxxxxx |
| In-reply-to: | <560050C9.2060602@xxxxxxxxxxx> |
| References: | <55FC4C37.7030709@xxxxxxxxxxx> <1305478563.35597179.1442806502755.JavaMail.zimbra@xxxxxxxxxx> <560050C9.2060602@xxxxxxxxxxx> |
| Reply-to: | Nathan Scott <nathans@xxxxxxxxxx> |
| Thread-index: | 8pddOnUrRBvZ7IAYHOijZN9sOCOtdw== |
| Thread-topic: | perfevent metric name changes |
----- Original Message -----
> [...]
> allow pmlogrewrite to allow the invalid names in the configuration file:
> [...]
> -[A-Za-z][A-Za-z0-9_.]* { yylval.str = dupstr(yytext, 0); return
> TOK_GNAME; }
> +[A-Za-z][A-Za-z0-9_.=-]* { yylval.str = dupstr(yytext, 0); return
> TOK_GNAME; }
>
> \#.* { }
>
Ah yes, that looks like a worthwhile change - we definitely want to
allow those kinds of metric names too so they can be fixed.
> This change and my script are in the same git branch. I just added the 2
> characters I have seen on our hardware. Is that acceptable? If so,
> I'll finish up the packaging and documentation.
Yep, sounds good to me - thanks Martins.
cheers.
--
Nathan
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [pcp] perfevent metric name changes, Martins Innus |
|---|---|
| Next by Date: | pcp updates: atop (wip), Nathan Scott |
| Previous by Thread: | Re: [pcp] perfevent metric name changes, Martins Innus |
| Next by Thread: | Re: [pcp] perfevent metric name changes, Martins Innus |
| Indexes: | [Date] [Thread] [Top] [All Lists] |