pcp
[Top] [All Lists]

perfevent metric name changes

To: pcp@xxxxxxxxxxx
Subject: perfevent metric name changes
From: Martins Innus <minnus@xxxxxxxxxxx>
Date: Fri, 18 Sep 2015 13:39:03 -0400
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
Hi,
We ran into some issues with the perfevent pmda where since we had used the names that libpfm provides directly, some of these names contain characters that cause problems with various pcp tools. These include "equals", "dash" and other similar things. The pmda API doesn't complain about these but other parts of PCP do. Here is a first hack at fixing this problem (and patch attached since its small):

https://github.com/ubccr/pcp/tree/perfevent_namechange

It includes a flag to preserve the old behavior. I looked into writing some rules for pmlogrewrite, but didn't see a way to do wholesale regex type substitutions. I'm not sure if there is a way to effectively do this since there are possibly hundreds of different metrics that could exist depending on your architecture. The metric names are generated on the fly from what libpfm provides.

Any thoughts on other ways to mitigate issues for others who may be using this pmda?

Thanks

Martins

Attachment: 39ad0b553341e39ae6ce7d58f5983a58866b1081.diff.txt
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>