libpcp pdubuf fix (was Re: pcp updates: libpcp, pcp-uptime, docs, qa)

[Nathan Scott <nathans@xxxxxxxxxx>]

----- Original Message -----
> 
> > Nathan Scott (5):
> >       libpcp: temporarily revert pdubuf tsearch-based optimisation
> 
> It turns out this is the right thing to do.

Never any doubt - stability over performance.

> [...]
> So a the pointer 0x1005da30 was deemed to fall into the interval of
> that first pdubuf 0x10050d8a0...0x10050da2f[400](10), when actually it
> is actually outside (by one byte).  Things go downhill very gradually
> from this point.  I'm testing a fix and qa, should be ready tomorrow.
> 

Great work!

Given the nature of where this change is in libpcp - i.e. affecting every
PMAPI collector and monitor tool ever - and with the reverted optimisation
affecting only pmwebd with multiple concurrent threads AIUI), I am leaning
toward going with the known-stable original pdubuf code for this release.

Let's tee this fix up with the other pending pcp-3.10.8 commits, and get
it merged in the first week to maximise soak time.  Thanks!

cheers.

--
Nathan