pcp
[Top] [All Lists]

[pcp] _pm_ispartition() heulistic miss some block devices (#45)

To: performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject: [pcp] _pm_ispartition() heulistic miss some block devices (#45)
From: Kazuo Moriwaka <notifications@xxxxxxxxxx>
Date: Wed, 26 Aug 2015 02:21:42 -0700
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1440580902; bh=7XSZjMtDML9DzonBHjNN2BLE2lWCRVds3Z9+b+xro4g=; h=From:Reply-To:To:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=FB/QnICsatzjdbPeFttPYIj2fJXR8weTNT9IcKMu2oq9TaI+DEbis38NEDdzXIKze pk41YIQ8Cujb3aijeVeYVJQuRy+DIgvl8p67wfQmCTUf1GKu1gdM9+htKqetTOz8YT urXvFQqUk9ZwGC2fsha+NGysHpa6wXqWWWo14T1o=
List-archive: https://github.com/performancecopilot/pcp
List-id: performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b6a78d8901d8060d655d5196bf4be0699d0e62fb0592cf0000000111f5472692a169ce062700ab@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b6a78d8901d8060d655d5196bf4be0699d0e62fb0592cf0000000111f5472692a169ce062700ab@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0ItvJEJyWNobrHbZG7oMm2v2gXLOVhks5orXymgaJpZM4FyZgl>
Reply-to: performancecopilot/pcp <reply+00bd08b6a78d8901d8060d655d5196bf4be0699d0e62fb0592cf0000000111f5472692a169ce062700ab@xxxxxxxxxxxxxxxx>

In src/pmdas/linux/proc_partitions.c, _pm_ispartition() use heulistic to detect partitions, but this misses some block devices like "sr0", "scd0", "fd0" etc.
I suggest using sysfs. /sys/block/* listing all block devices.

Thanks,


Reply to this email directly or view it on GitHub.

<Prev in Thread] Current Thread [Next in Thread>